Skip to content

Fix getIp() in release mode #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qiluo-msft wants to merge 1 commit into from
Closed

Fix getIp() in release mode #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/ipprefix.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class IpPrefix
return m_ip.isV4();
}

inline const IpAddress getIp() const
inline const IpAddress& getIp() const
{
return m_ip;
}
Expand Down Expand Up @@ -50,11 +50,11 @@ class IpPrefix
ipa.ip_addr.ipv6_addr[mid] = 0xFF << left;
memset(ipa.ip_addr.ipv6_addr, 0xFF, mid);
memset(ipa.ip_addr.ipv6_addr + mid + 1, 0, 16 - mid - 1);
return ipa;
return IpAddress(ipa);
}
default:
{
assert(false);
throw new std::logic_error("Invalid family");
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ bin_PROGRAMS = tests
if DEBUG
DBGFLAGS = -ggdb -DDEBUG
else
DBGFLAGS = -g
DBGFLAGS = -g -DNDEBUG
endif

CFLAGS_GTEST = -I $(top_srcdir)/googletest/googletest/include
Expand Down