[MultiDB] libswsscommon.deb install default database_config.json if it doesn't exist#315
[MultiDB] libswsscommon.deb install default database_config.json if it doesn't exist#315dzhangalibaba wants to merge 2 commits intosonic-net:masterfrom
Conversation
|
retest this please |
| DST_PATH="/var/run/redis/sonic-db" | ||
| DST_FILE="database_config.json" | ||
| SRC_PATH="/usr/share/swss" | ||
| # if there is no $DST_FILE, it is for testing, it is needed to copy one default $DST_FILE |
There was a problem hiding this comment.
if there is no $DST_FILE, it is for testing, it is needed to copy one default $DST_FILE [](start = 2, length = 87)
For vs test, libswsscommon is installed on the host, and python code will call it. Is your PR for this case? If yes, it does not make sense to cp to host DST_PATH.
There was a problem hiding this comment.
yes . it is for vs test cases. cp file on host:DST_PATH make sense.
when conftest.py run vs, it mount host:/var/run/redis-vs/{sw_name} to vs:var/run/redis/, so we need to copy the host:/var/run/redis/sonic-db/database_config.json to host:/var/run/redis-vs/{sw_name}/sonic-db/ and the vs can use this database_config.json file. thsi is done at sonic-net/sonic-swss#1131
I am not sure why the mount name is different from /var/run/redis/, if it is the same like /var/run/redis/:/var/run/redis/, then we don't need the copy and just this PR is enough.
|
will do changes in docker-sonic-vs images itself instead of using libswsscommon |
…onic-net#315) * Add get_transceiver_status to API interface * Add test_ccmis support * Add get_transceiver_pm API interface * Add debug log and more description for interface * Remove unnecessary pass
2 participants
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com