Merged
Conversation
prsunny
reviewed
Aug 1, 2019
common/schema.h
Outdated
| #define APP_PASS_THROUGH_ROUTE_TABLE_NAME "PASS_THROUGH_ROUTE_TABLE" | ||
| #define APP_ACL_TABLE_TABLE_NAME "ACL_TABLE_TABLE" | ||
| #define APP_ACL_RULE_TABLE_NAME "ACL_RULE_TABLE" | ||
| #define APP_SFLOW_TABLE_NAME "SFLOW_TABLE" |
Contributor
There was a problem hiding this comment.
can you align this with rest of the entries?
Indentation changes
dgsudharsan
force-pushed
the
sflowtables
branch
from
84efd79 to
986c720
Compare
prsunny
approved these changes
Aug 5, 2019
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
* catch Exception to avoid CMIS code crash Signed-off-by: Kebo Liu <kebol@nvidia.com> * fix review comments, add more UT test Signed-off-by: Kebo Liu <kebol@nvidia.com> Signed-off-by: Kebo Liu <kebol@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Defined APPL DB and and CONFIG DB tables for SFLOW feature
Why I did it
How I verified it
Details if related