[IpAddress]: add mcast scope on address and isFullMask method on prefix#285
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jun 29, 2019
Merged
[IpAddress]: add mcast scope on address and isFullMask method on prefix#285lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
Contributor
tylerlinp
commented
Jun 19, 2019
tylerlinp
commented
- add mcast scope on IpAddress class
- add isFullMask method on IpPrefix class
tylerlinp
changed the title
Contributor
|
add some unittests for those changes ? |
Contributor
Author
|
Yes, in sonic-swss PR: |
Contributor
|
unit test code should be in this repo. |
Contributor
Author
|
OK. Unit test code has been added. |
kcudnik
approved these changes
Jun 24, 2019
prsunny
approved these changes
Jun 24, 2019
stcheng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.