Warm reboot: Add support for bool Select::hasCachedSelectable()#214
Warm reboot: Add support for bool Select::hasCachedSelectable()#214lguohan merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Jipan Yang <[email protected]>
|
hasCachedSelectable() is a misleading name for me. What do you think? |
|
@pavel-shirshov I don't have strong opinion as to the function name. Actually it took me several iterations to just get current name. |
|
Yes, m_queue is a sort of priority queue |
…mpty() Signed-off-by: Jipan Yang <[email protected]>
jipanyang
changed the title
common/select.cpp
Outdated
| } | ||
|
|
||
| }; | ||
| bool Select::isQueueNonEmpty() |
There was a problem hiding this comment.
isQueueNonEmpty [](start = 13, length = 15)
Prefer positive adj.
isQueueEmpty
Signed-off-by: Jipan Yang <[email protected]>
|
@jipanyang Is this new function used somewhere? I think it just expose some internal implementation details, and the implementation will possible be changed in near future. Why it is useful? Can we remove it? |
…() (sonic-net#214)" This reverts commit c5d5434.
…() (sonic-net#214)" This reverts commit c5d5434.
Signed-off-by: Prince George <[email protected]>
4 participants
Signed-off-by: Jipan Yang [email protected]
For warm restart state restore, there is need to check if all cached selectables have been processed.