Use references when it's possible and other small enhancements.

[pavel-shirshov]

1. Use references as loop arguments
2. Initialize class fields in initializer list
3. Don't use std::move for return value
4. Don't use compare method to compare two strings for equality
5. Fix typo

[qiluo-msft]

if [](start = 8, length = 2)

if (ctx->type == REDIS_REPLY_NIL)
{
    SWSS_LOG_ERROR("Got EMPTY response type from redis %d", ctx->type);
}

else if (ctx->type != REDIS_REPLY_ARRAY)
{
    SWSS_LOG_ERROR("Got invalid response type from redis %d", ctx->type);
}
else
{
    for (size_t i = 0; i < ctx->elements; i++)
    {
        SWSS_LOG_DEBUG("Got element %lu %s", i, ctx->element[i]->str);
        ret.insert(ctx->element[i]->str);
    }
}
return ret;

[pavel-shirshov]

I don't see any comments here

[jleveque]

I believe Qi is presenting a refactored, simplified block of code to replace the entire block with. Note only one return statement. Not so much a comment, but rather a suggested replacement.

[qiluo-msft]

As comment