Pass arguments by references for constructors and methods#197
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom Apr 28, 2018
Merged
Pass arguments by references for constructors and methods#197pavel-shirshov merged 1 commit intosonic-net:masterfrom
pavel-shirshov merged 1 commit intosonic-net:masterfrom
Conversation
qiluo-msft
approved these changes
Apr 28, 2018
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
…-net#197) Unifying the platform api for get_pcie_aer_stats with PcieBase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass complex arguments by references, don't copy them.
That will save us some time + reduce number of allocations/deallocations.
I've fixed also some #includes which were wrong, use find specially designed for characters