Fix the C++ unit tests. Use more specific EXPECT_ clauses#195
Merged
pavel-shirshov merged 3 commits intosonic-net:masterfrom Apr 13, 2018
Merged
Fix the C++ unit tests. Use more specific EXPECT_ clauses#195pavel-shirshov merged 3 commits intosonic-net:masterfrom
pavel-shirshov merged 3 commits intosonic-net:masterfrom
Conversation
qiluo-msft
approved these changes
Apr 13, 2018
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
…on. (sonic-net#195) Platform vendor can add their own logic to determine the pcie conifiguration revision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've converted a lot of EXPECT_TRUE to EXPECT_EQ, EXPECT_NE, EXPECT_LE which allows us to see wrong values when the test isn't correct.
For example it's hard to see values here: