Extending IpPrefix class to return the subnet associated to any given prefix#184
Merged
lguohan merged 2 commits intosonic-net:masterfrom Feb 8, 2018
Merged
Conversation
… prefix.
This method is being currently utilized by the new interface's overlapping-detection logic (to be submitted under a different sonic-swss PR). Method's goal is to simply return the subnet associated to any given prefix (see example below). A new pytest testcase will be appended shortly.
Examples:
subnet("10.1.1.1/24") = 10.1.1.0/24
subnet("fc00:0003:0002:0002::2/64") = fc00:0003:0002:0002:0000:0000:0000:0000/64
Contributor
|
please add unit test. |
lguohan
requested changes
Jan 29, 2018
Contributor
lguohan
left a comment
lguohan
left a comment
There was a problem hiding this comment.
can you add unit test for this new function.
Contributor
Author
|
UT's created. Please review when have a chance. |
prsunny
approved these changes
Feb 8, 2018
lguohan
approved these changes
Feb 8, 2018
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
…ties (sonic-net#184) Added a `get_revision()` method to the generic platform device class which returns the hardware revision number of the device as a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is being currently utilized by the new interface's overlapping-detection logic (to be submitted under a different PR within sonic-swss repo). Method's goal is to simply return the subnet associated to any given prefix (see example below). A new pytest testcase will be appended shortly.
Examples:
subnet("10.1.1.1/24") = 10.1.1.0/24
subnet("fc00:0003:0002:0002::2/64") = fc00:0003:0002:0002:0000:0000:0000:0000/64