Table class supports redis pipeline#181
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Jan 26, 2018
Merged
Conversation
Signed-off-by: Qi Luo <[email protected]>
sihuihan88
approved these changes
Jan 25, 2018
lguohan
reviewed
Jan 26, 2018
| DBConnector db(TEST_VIEW, "localhost", 6379, 0); | ||
| Table t(&db, tableName); | ||
| RedisPipeline pipeline(&db); | ||
| Table t(&pipeline, tableName, DEFAULT_TABLE_NAME_SEPARATOR, true); |
Contributor
There was a problem hiding this comment.
@sihuihan88 , you need follow this example to enable redispipeline in your scenario.
lguohan
reviewed
Jan 26, 2018
| Table(DBConnector *db, std::string tableName, std::string tableSeparator = DEFAULT_TABLE_NAME_SEPARATOR); | ||
| virtual ~Table() { } | ||
| Table(RedisPipeline *pipeline, std::string tableName, std::string tableSeparator, bool buffered); | ||
| virtual ~Table(); |
Contributor
There was a problem hiding this comment.
why remove the implementation for the Table deconstructor?
Contributor
Author
There was a problem hiding this comment.
Actually not removed. I implemented with non-empty logic in .cpp file
lguohan
approved these changes
Jan 26, 2018
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
Testbeds using the mux simulator will see lots of error messages in the syslog since many y_cable methods are not mocked for the mux simulator. This PR prepares `y_cable.py` to use mocked methods that will be introduced in a future sonic-mgmt PR. Signed-off-by: Lawrence Lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.