Conversation
This reverts commit d630d57.
kcudnik
approved these changes
Jan 16, 2018
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
… in SFP plugin (sonic-net#177) - Import of sonic_platform before logger when platform API is not available leads to non import of logger resulting in xcvrd crash - Since string and byte comparison returns true in python2 current check for differentiating python2 and 3 in EEPROM read fails. Co-authored-by: V P Subramaniam <Subramaniam_Vellalap@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #176