Skip to content

Add RedisClient to pyext #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lguohan merged 1 commit into from
Jan 15, 2018
Merged

Add RedisClient to pyext #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions common/redisclient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,23 +32,23 @@ class RedisClient

std::vector<std::string> keys(std::string key);

std::vector<std::string> hkeys(std::string key);
//std::vector<std::string> hkeys(std::string key);
Copy link
Copy Markdown
Contributor

@lguohan lguohan Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we comment them?

Copy link
Copy Markdown
Contributor Author

@kcudnik kcudnik Jan 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swig is complaining that there is no implementation for those methods since i just left signature for those mthods, but there is no implementation yet


void set(std::string key, std::string value);

void hset(std::string key, std::string field, std::string value);

void mset(std::unordered_map<std::string, std::string> map);
//void mset(std::unordered_map<std::string, std::string> map);

void hmset(std::string key, std::unordered_map<std::string, std::string> map);
//void hmset(std::string key, std::unordered_map<std::string, std::string> map);

std::shared_ptr<std::string> get(std::string key);

std::shared_ptr<std::string> hget(std::string key, std::string field);

std::vector<std::shared_ptr<std::string>> mget(std::vector<std::string> keys);
//std::vector<std::shared_ptr<std::string>> mget(std::vector<std::string> keys);

std::vector<std::shared_ptr<std::string>> hmget(std::string key, std::vector<std::string> fields);
//std::vector<std::shared_ptr<std::string>> hmget(std::string key, std::vector<std::string> fields);

int64_t incr(std::string key);

Expand Down
2 changes: 2 additions & 0 deletions pyext/swsscommon.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
#include "redispipeline.h"
#include "redisselect.h"
#include "redistran.h"
#include "redisclient.h"
#include "producerstatetable.h"
#include "consumertablebase.h"
#include "consumerstatetable.h"
Expand Down Expand Up @@ -78,3 +79,4 @@
%clear std::vector<std::pair<std::string, std::string>> &values;

%include "notificationproducer.h"
%include "redisclient.h"