Skip to content

Add more logging to redisreply when error happens #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcudnik merged 1 commit into from
May 3, 2016
Merged

Add more logging to redisreply when error happens #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions common/redisreply.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,19 @@ RedisReply::RedisReply(DBConnector *db, string command, int exepectedType, bool

if (!m_reply)
{
SWSS_LOG_ERROR("Redis reply is NULL, memory exception");
SWSS_LOG_ERROR("Redis reply is NULL, memory exception, command: %s", command.c_str());

throw system_error(make_error_code(errc::not_enough_memory),
"Memory exception");
"Memory exception, reply is null");
}

if (m_reply->type != exepectedType)
{
SWSS_LOG_ERROR("Expected to get redis type %d got type %d, command: %s",
exepectedType, m_reply->type, command.c_str());
const char *err = (m_reply->type == REDIS_REPLY_STRING || m_reply->type == REDIS_REPLY_ERROR) ?
m_reply->str : "NON-STRING-REPLY";

SWSS_LOG_ERROR("Expected to get redis type %d got type %d, command: %s, err: %s",
exepectedType, m_reply->type, command.c_str(), err);
freeReplyObject(m_reply);
m_reply = NULL; /* Some compilers call destructor in this case */

Expand Down