Add stateDB table name for lag and vlan#143
Merged
lguohan merged 1 commit intosonic-net:masterfrom Oct 13, 2017
Merged
Conversation
stcheng
reviewed
Oct 10, 2017
common/schema.h
Outdated
| /***** STATE DATABASE *****/ | ||
|
|
||
| #define STATE_PORT_TABLE_NAME "PORT_TABLE" | ||
| #define STATE_LAG_TABLE_NAME "PORTCHANNEL_TABLE" |
Contributor
There was a problem hiding this comment.
I would suggest to change it to LAG_TABLE. I add comments on the schema pull request in the other repository.
Contributor
Author
There was a problem hiding this comment.
Yes, LAG_TABLE is more aligned with APPL_DB. How about also have "INTERFACE_TABLE" updated to "INTF_TABLE"?
It looks current python part of code changes had cfgDB taking a quite different table naming style.
Contributor
Author
There was a problem hiding this comment.
Changed to #define STATE_LAG_TABLE_NAME "LAG_TABLE"
Signed-off-by: Jipan Yang <[email protected]>
53ada76 to
cebb539
Compare
Contributor
Author
|
Changed to #define STATE_LAG_TABLE_NAME "LAG_TABLE" |
stcheng
approved these changes
Oct 11, 2017
prgeor
pushed a commit
to prgeor/sonic-swss-common
that referenced
this pull request
Feb 27, 2025
1. Fix name error in psu_base.py 2. change absolute import to relative import for sff8024
Pterosaur
pushed a commit
to Pterosaur/sonic-swss-common
that referenced
this pull request
Apr 13, 2025
Our patches to the goyang/ygot library add performance optimizations by including a mutex protected cache (map) in the Entry struct. The ygot library makes copies of Entry objects during unmarshal operations which is not safe given our changes. This change moves the cache and mutex to a separate struct and adds a pointer to the new struct into the Entry struct. Now copies of Entry structs will result in both copies sharing the same cache and avoid issues around copying mutexes and maps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang [email protected]