Skip to content

Add stateDB table name for lag and vlan#143

Merged
lguohan merged 1 commit intosonic-net:masterfrom
jipanyang:lag_vlan_stateDB_table_name
Oct 13, 2017
Merged

Add stateDB table name for lag and vlan#143
lguohan merged 1 commit intosonic-net:masterfrom
jipanyang:lag_vlan_stateDB_table_name

Conversation

@jipanyang
Copy link
Copy Markdown
Contributor

Signed-off-by: Jipan Yang [email protected]

common/schema.h Outdated
/***** STATE DATABASE *****/

#define STATE_PORT_TABLE_NAME "PORT_TABLE"
#define STATE_LAG_TABLE_NAME "PORTCHANNEL_TABLE"
Copy link
Copy Markdown
Contributor

@stcheng stcheng Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to change it to LAG_TABLE. I add comments on the schema pull request in the other repository.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LAG_TABLE is more aligned with APPL_DB. How about also have "INTERFACE_TABLE" updated to "INTF_TABLE"?

It looks current python part of code changes had cfgDB taking a quite different table naming style.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to #define STATE_LAG_TABLE_NAME "LAG_TABLE"

@jipanyang jipanyang force-pushed the lag_vlan_stateDB_table_name branch from 53ada76 to cebb539 Compare October 11, 2017 00:15
@jipanyang
Copy link
Copy Markdown
Contributor Author

Changed to #define STATE_LAG_TABLE_NAME "LAG_TABLE"

@lguohan lguohan merged commit db3ed91 into sonic-net:master Oct 13, 2017
@jipanyang jipanyang deleted the lag_vlan_stateDB_table_name branch June 7, 2018 02:11
prgeor pushed a commit to prgeor/sonic-swss-common that referenced this pull request Feb 27, 2025
1. Fix name error in psu_base.py
2. change absolute import to relative import for sff8024
Pterosaur pushed a commit to Pterosaur/sonic-swss-common that referenced this pull request Apr 13, 2025
Our patches to the goyang/ygot library add performance optimizations by
including a mutex protected cache (map) in the Entry struct.  The ygot
library makes copies of Entry objects during unmarshal operations which
is not safe given our changes.  This change moves the cache and mutex to
a separate struct and adds a pointer to the new struct into the Entry
struct.  Now copies of Entry structs will result in both copies sharing
the same cache and avoid issues around copying mutexes and maps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants