Skip to content

Improve performance on table set command#13

Merged
kcudnik merged 2 commits intosonic-net:masterfrom
kcudnik:perf
Apr 29, 2016
Merged

Improve performance on table set command#13
kcudnik merged 2 commits intosonic-net:masterfrom
kcudnik:perf

Conversation

@kcudnik
Copy link
Copy Markdown
Contributor

@kcudnik kcudnik commented Apr 28, 2016

No description provided.

common/table.cpp Outdated
@@ -73,9 +73,8 @@ void Table::set(std::string key, std::vector<FieldValueTuple> &values,
{
/* We are doing transaction for AON (All or nothing) */
multi();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mulit is not needed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Apr 29, 2016

ack

@kcudnik kcudnik merged commit 4e103b7 into sonic-net:master Apr 29, 2016
@kcudnik kcudnik deleted the perf branch April 29, 2016 17:29
zbud-msft pushed a commit to zbud-msft/sonic-swss-common that referenced this pull request Aug 19, 2022
prgeor pushed a commit to prgeor/sonic-swss-common that referenced this pull request Feb 27, 2025
Pterosaur pushed a commit to Pterosaur/sonic-swss-common that referenced this pull request Apr 13, 2025
- Why I did it

There are few issues in cvl and translib go test code.

- How I did it

1) Fixed compilation is translib test code. Temporarily disabled ACL test codes from translib test since there are too many errors in it. Moved all common utility code in ACL test file into a new common file (app_utils_test.go).
2) Fixed the failures in cvl test code.
3) Added a new app module api_tests_app.go which provides dummy implementations of all app interface APIs for paths starting with /api-tests:. Errors can be simulated by including token /error/ in the path. This can be used by translib test code as well as translib client test code (REST or telemetry) to verify end-to-end of all cases without depending on actual app modules or database state.

- How to verify it

Run translib and cvl go test cases

- Description for the changelog

Cleanup translib and cvl go test cases
nazariig pushed a commit to nazariig/sonic-swss-common that referenced this pull request May 6, 2025
…412 (sonic-net#13)

```<br>* fe429b6 - (HEAD -> 202412) Merge branch '202411' of https://github.com/sonic-net/sonic-swss-common into 202412 (2025-02-20) [Sonic Automation]
* 7aa1a47 - (origin/202411) Added field for policer counter (sonic-net#975) (2025-02-19) [mssonicbld]
* 8f47a37 - Handle 'bulkget' in consumer_table_pops.lua (sonic-net#970) (2025-02-07) [mssonicbld]<br>```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants