Skip to content

[sonic-db-cli] Fix argument parsing skipping namespace#1111

Merged
qiluo-msft merged 3 commits intosonic-net:masterfrom
croos12:db_namespace_fix
Dec 2, 2025
Merged

[sonic-db-cli] Fix argument parsing skipping namespace#1111
qiluo-msft merged 3 commits intosonic-net:masterfrom
croos12:db_namespace_fix

Conversation

@croos12
Copy link
Contributor

@croos12 croos12 commented Nov 18, 2025

Fixes sonic-db-cli argument parsing skipping namespace argument by explicitly setting the options in getopt to select the next space delimitated argument to be namespace and container_name

@croos12
Fix issue where namespace would not be read
9d88348 
Signed-off-by: Connor Roos <croos@nvidia.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 18, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@croos12 croos12 changed the title Fix sonic-db-cli argument parsing missing namespace [ sonic-db-cli] Fix argument parsing missing namespace Nov 18, 2025
@croos12 croos12 changed the title [ sonic-db-cli] Fix argument parsing missing namespace [sonic-db-cli] Fix argument parsing missing namespace Nov 18, 2025
@croos12 croos12 mentioned this pull request Nov 18, 2025
Closed
@croos12
Copy link
Contributor Author

croos12 commented Nov 18, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 18, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@croos12
Copy link
Contributor Author

croos12 commented Nov 19, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 19, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@croos12
Copy link
Contributor Author

croos12 commented Nov 21, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 21, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@croos12 croos12 changed the title [sonic-db-cli] Fix argument parsing missing namespace [sonic-db-cli] Fix argument parsing skipping namespace Nov 21, 2025
@croos12
Copy link
Contributor Author

croos12 commented Nov 21, 2025

@qiluo-msft can you review this PR? It fixes a bug that was introduced for multi-asic after this PR: #1070

@qiluo-msft
Copy link
Contributor

qiluo-msft commented Nov 21, 2025

How did you test (old code vs this PR)? Could you add unit test?

qiluo-msft
qiluo-msft reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm. Suggest add test result in PR description and consider adding testcases.

@croos12
Copy link
Contributor Author

croos12 commented Nov 21, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 21, 2025

/AzurePipelines run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 21, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@croos12
Copy link
Contributor Author

croos12 commented Nov 24, 2025

@qiluo-msft we have unit tests that should cover this, but it looks like the behavior is not consistent. I had to test it by running it directly on the switch with print statements (this switch was a smartswitch so it had dpu databases but not asics) and I could see that the tool was not populating the namespace variable from the parameter :

image

@mssonicbld
Copy link
Collaborator

mssonicbld commented Nov 25, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 25, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@saiarcot895 saiarcot895 mentioned this pull request Dec 2, 2025
Closed
9 tasks
@qiluo-msft qiluo-msft merged commit cf7c7f6 into sonic-net:master Dec 2, 2025
18 checks passed
@saiarcot895
Copy link
Contributor

saiarcot895 commented Dec 2, 2025

@croos12 Can you confirm that this fixes multi-ASIC bringup? It didn't appear to work for me.

qiluo-msft added a commit to qiluo-msft/sonic-swss-common that referenced this pull request Dec 3, 2025
@qiluo-msft
Revert "Fix issue where namespace would not be read (sonic-net#1111)"
e7bcc4d 
This reverts commit cf7c7f6.
@qiluo-msft qiluo-msft mentioned this pull request Dec 3, 2025
Merged
qiluo-msft added a commit that referenced this pull request Dec 3, 2025
@qiluo-msft
Revert "[sonic-db-cli] Add flag to make cli calls to container databa…
7f1b50f 
…ses (#1070)" and #1111 (#1123)

Due to #1100
To unblock submodule move

Revert 2 PRs:
cf7c7f6 2025-12-01 | Fix issue where namespace would not be read (#1111) [Connor Roos]
4fea06e 2025-10-07 | [sonic-db-cli] Add flag to make cli calls to container databases (#1070) [Connor Roos]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees

No one assigned

Labels

Request for 202511 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@croos12 @mssonicbld @qiluo-msft @saiarcot895 @vmittal-msft @prabhataravind