Add lazy binding support to ZmqServer.#1068
Merged
qiluo-msft merged 9 commits intosonic-net:masterfrom Aug 21, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
approved these changes
Aug 19, 2025
r12f
reviewed
Aug 19, 2025
| SWSS_LOG_ENTER(); | ||
| if (m_socket) | ||
| { | ||
| SWSS_LOG_THROW("ZmqServer has already been bound to the endpoint: %s", m_endpoint.c_str()); |
Contributor
There was a problem hiding this comment.
do we need to consider this bind as no-op instead of throw?
Contributor
Author
There was a problem hiding this comment.
A ZMQ server should only be bound once.
To catch potential issues during development, I recommend throwing an exception if a second bind attempt is detected. This will help identify incorrect usage early and ensure proper lifecycle management of the server.
Contributor
There was a problem hiding this comment.
gotcha! so it is an explicit lazy binding instead of implicit one. makes sense!
r12f
approved these changes
Aug 20, 2025
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Aug 30, 2025
Fix DPU restart message drop by Zmq lazy bind. #### Why I did it Fix issue: sonic-net/sonic-buildimage#23110 When creating a ZmqServer followed by a ZmqProducerStateTable, there may be a time gap between the server starting to receive messages and the producer state table registering its handler. This gap can lead to dropped messages. To avoid this, use lazy binding and invoke bind() only after the handler is registered. #### How I did it Update Orchagent to use lazy binding for ZMQ. ZMQ is now created with lazy bind in Orchagent, and the bind() operation is deferred until all ZmqProducerStateTable instances have been initialized. This ensures handlers are registered before any messages are received, preventing potential data loss during startup. This PR depends on sonic-net/sonic-swss-common#1068 ##### Work item tracking - Microsoft ADO: 33995986 #### How to verify it Pass all test cases. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog Fix DPU restart message drop by Zmq lazy bind. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration. --> #### A picture of a cute animal (not mandatory but encouraged)
6 tasks
mssonicbld
added a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Aug 30, 2025
Fix DPU restart message drop by Zmq lazy bind. #### Why I did it Fix issue: sonic-net/sonic-buildimage#23110 When creating a ZmqServer followed by a ZmqProducerStateTable, there may be a time gap between the server starting to receive messages and the producer state table registering its handler. This gap can lead to dropped messages. To avoid this, use lazy binding and invoke bind() only after the handler is registered. #### How I did it Update Orchagent to use lazy binding for ZMQ. ZMQ is now created with lazy bind in Orchagent, and the bind() operation is deferred until all ZmqProducerStateTable instances have been initialized. This ensures handlers are registered before any messages are received, preventing potential data loss during startup. This PR depends on sonic-net/sonic-swss-common#1068 ##### Work item tracking - Microsoft ADO: 33995986 #### How to verify it Pass all test cases. #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 #### Description for the changelog Fix DPU restart message drop by Zmq lazy bind. #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/SONiC/wiki/Configuration. --> #### A picture of a cute animal (not mandatory but encouraged)
6 tasks
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-swss-common.msft#54 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add lazy binding support to ZmqServer.
Why I did it
When creating a ZmqServer followed by a ZmqProducerStateTable, there may be a time gap between the server starting to receive messages and the producer state table registering its handler.
This gap can lead to dropped messages. To avoid this, use lazy binding and invoke bind() only after the handler is registered.
How I did it
Add lazy binding support to ZmqServer.
Work item tracking
How to verify it
Pass all test cases.
Add new test case for lazy binding.
Pass all sonic-mgmt test with this PR:
sonic-net/sonic-buildimage#23741
Which release branch to backport (provide reason below if selected)
Description for the changelog
Add lazy binding support to ZmqServer.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)