changes needed in test file for SNMP docker upgrade to stretch build

[samaity]

Signed-off-by: Sangita Maity [email protected]

- What I did

I was getting error during SNMP docker upgrade to stretch build because of one test file i.e. test_nexthop.py . Commented out some lines just to build SNMP Docker.

Provided the error log->

======================================================================
FAIL: test_getnextpdu (tests.test_nexthop.TestForwardMIB)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/sonic/src/sonic-snmpagent/tests/test_nexthop.py", line 65, in test_getnextpdu
    self.assertEqual(value0.type_, ValueType.IP_ADDRESS)
AssertionError: <ValueType.END_OF_MIB_VIEW: 130> != <ValueType.IP_ADDRESS: 64>

======================================================================
FAIL: test_getnextpdu_exactmatch (tests.test_nexthop.TestForwardMIB)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/sonic/src/sonic-snmpagent/tests/test_nexthop.py", line 82, in test_getnextpdu_exactmatch
    self.assertEqual(value0.type_, ValueType.IP_ADDRESS)
AssertionError: <ValueType.END_OF_MIB_VIEW: 130> != <ValueType.IP_ADDRESS: 64>

======================================================================
FAIL: test_getpdu (tests.test_nexthop.TestForwardMIB)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/sonic/src/sonic-snmpagent/tests/test_nexthop.py", line 46, in test_getpdu

- How I did it
Commented out some lines just to build SNMP Docker.

- How to verify it
Use this PR with snmp docker upgrade PR in sonic-buildimage.

[jleveque]

According to the errors you posted, AssertionError: <ValueType.END_OF_MIB_VIEW: 130> != <ValueType.IP_ADDRESS: 64> seems to be a real issue -- it looks the it grabbed the wrong data. I think commenting out these assertEqual's is the wrong thing to do, as it appears to be masking a real issue.

[samaity]

I thought the same. need some help in this. Do you have any idea?

[xinliu-seattle]

@qiluo-msft please help you to take a look.

[lguohan]

please do not comment the assert.

[qiluo-msft]

@samaity Could you please run and compare below command output

# pip3.6 list -l
Package               Version
--------------------- -------
asyncsnmp             2.1.0
hiredis               1.0.0
pip                   19.0.3
psutil                5.6.1
python-arptable       0.0.2
PyYAML                5.1
redis                 2.10.6
setuptools            40.8.0
sonic-platform-common 1.0
swsssdk               2.0.1
wheel                 0.33.1

Is there a PR that you build a new docker image? We would like to test in the same environment as yours.

[samaity]

@qiluo-msft , sonic-net/sonic-buildimage#2620 is the PR

[samaity]

This is the list

root@lnos-x1-a-csw04:/# pip3.6 list -l
Package               Version
--------------------- -------
asyncsnmp             2.1.0
hiredis               1.0.0
pip                   19.0.3
psutil                5.5.1
python-arptable       0.0.2
PyYAML                3.13
redis                 2.10.6
setuptools            40.8.0
sonic-platform-common 1.0
swsssdk               2.0.1
wheel                 0.33.1

[qiluo-msft]

As you can see, psutil & PyYAML package version changes, and I highly suspect PyYAML brought some disruptive change, or maybe both brought. Could you try uninstall and install the exact same version packages and rerun the test?

[samaity]

I installed psutil and PyYAML to the exact version. still got the issue.

root@lnos-x1-a-csw04:/# pip3.6 list -l
Package               Version
--------------------- -------
asyncsnmp             2.1.0
hiredis               1.0.0
pip                   19.0.3
psutil                5.6.1
python-arptable       0.0.2
PyYAML                5.1
redis                 2.10.6
setuptools            40.8.0
sonic-platform-common 1.0
swsssdk               2.0.1
wheel                 0.33.1

[qiluo-msft]

It turns out vanilla 'python3 setup.py test' does not work. Using py.test everything is fine.