Get Vlan Id from ASIC_STATE Vlan Object if bvid present#62
Merged
prsunny merged 2 commits intosonic-net:masterfrom Jan 30, 2018
Merged
Get Vlan Id from ASIC_STATE Vlan Object if bvid present#62prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
yxieca
approved these changes
Jan 30, 2018
| return (int(fdb["vlan"]),) + mac_decimals(fdb["mac"]) | ||
| elif 'bvid' in fdb: | ||
| vlan_id = port_util.get_vlan_id_from_bvid(db_conn, fdb["bvid"]) | ||
| return (int(vlan_id),) + mac_decimals(fdb["mac"]) |
Contributor
There was a problem hiding this comment.
I don't feel this is a must-change;
I would assign vlan_id in both if and elif branches and return the vlanmac from a same statement, for the sake of consistency.
lguohan
approved these changes
Jan 30, 2018
yxieca
approved these changes
Jan 30, 2018
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sonic-snmpagent
that referenced
this pull request
May 23, 2025
* Get Vlan Id from ASIC_STATE Vlan Object if bvid present * Address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API reference : sonic-net/sonic-py-swsssdk#30