[rfc4364]: Add extra condition to deal with init scenario#44
Closed
stcheng wants to merge 1 commit intosonic-net:masterfrom
Closed
[rfc4364]: Add extra condition to deal with init scenario#44stcheng wants to merge 1 commit intosonic-net:masterfrom
stcheng wants to merge 1 commit intosonic-net:masterfrom
Conversation
When snmp subagent starts, the self.if_bpid_map is not initialized. Add the extra condition to prevent NoneType from being iterated. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
qiluo-msft
reviewed
Oct 17, 2017
| # Example output: oid:0x3a000000000608 | ||
| bridge_port_id = ent[b"SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID"][6:] | ||
| if bridge_port_id not in self.if_bpid_map: | ||
| if not self.if_bpid_map or bridge_port_id not in self.if_bpid_map: |
Contributor
There was a problem hiding this comment.
Should we fix get_bridge_port_map to return empty dict instead of None?
Contributor
Author
|
close this pull request in favor of sonic-net/sonic-py-swsssdk#17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When snmp subagent starts, the self.if_bpid_map is not initialized.
Add the extra condition to prevent NoneType from being iterated.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com