Skip to content

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. #293

Merged
qiluo-msft merged 3 commits intomasterfrom
dev/liuh/fix-pipeline3
Sep 16, 2023
Merged

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect. #293
qiluo-msft merged 3 commits intomasterfrom
dev/liuh/fix-pipeline3

Conversation

@liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Sep 15, 2023

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.

Pipeline build break because sonic-buildimage repo not build libhredis by this PR: sonic-net/sonic-buildimage#15633

- What I did
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.

- How I did it
Install libhiredis0.14 from debian apt source.

- How to verify it
Pass all UT

- Description for the changelog
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.

@liuh-80 liuh-80 requested a review from qiluo-msft September 15, 2023 05:11
@liuh-80 liuh-80 marked this pull request as ready for review September 15, 2023 05:11
set -ex
sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev
sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_*.deb,libnl-genl-3-200_*.deb,libnl-nf-3-200_*.deb,libnl-route-3-200_*.deb,libhiredis0.14_*.deb}
sudo apt-get -y install libhiredis0.14
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libhiredis0

Do you want to install libhiredis-dev?
#Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the original pipeline only install libhiredis0.14, I want keeps no change.

@@ -50,7 +50,8 @@ stages:
- script: |
set -ex
sudo apt-get -y purge libhiredis-dev libnl-3-dev libnl-route-3-dev
Copy link
Contributor

@qiluo-msft qiluo-msft Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libhiredis-dev

The intention of purging is to remove all the self-build packages from the env. Since it is not self-build anymore, will this line fail? do you want to stop purge this package? #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I want keep this line no change, only install missing libhiredis0.14.
Also the next line, does not install self-build libhiredis-dev:

sudo dpkg -i ../target/debs/buster/{libyang_1.0.73_amd64.deb,libswsscommon_1.0.0_amd64.deb,python3-swsscommon_1.0.0_amd64.deb,libnl-3-200_.deb,libnl-genl-3-200_.deb,libnl-nf-3-200_.deb,libnl-route-3-200_.deb}

@qiluo-msft qiluo-msft merged commit 00d8363 into master Sep 16, 2023
ssithaia-ebay pushed a commit to ssithaia-ebay/sonic-snmpagent that referenced this pull request May 23, 2025
…mage artifect. (sonic-net#293)

Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.

Pipeline build break because sonic-buildimage repo not build libhredis by this PR: sonic-net/sonic-buildimage#15633

**- What I did**
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.

**- How I did it**
Install libhiredis0.14 from debian apt source.

**- How to verify it**
Pass all UT

**- Description for the changelog**
Fix pipeline build break caused by libhredis remove from sonic-buildimage artifect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants