Skip to content

Don't cache the vlan-id if it is not valid from DB #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 1 commit into from
Nov 14, 2022
Merged

Don't cache the vlan-id if it is not valid from DB #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sonic_ax_impl/mibs/ietf/rfc4363.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ def fdb_vlanmac(self, fdb):
vlan_id = Namespace.dbs_get_vlan_id_from_bvid(self.db_conn, fdb["bvid"])
if isinstance(vlan_id, bytes):
vlan_id = vlan_id.decode()
self.bvid_vlan_map[fdb["bvid"]] = vlan_id
# only cache vlan_id if valid
if vlan_id is not None:
self.bvid_vlan_map[fdb["bvid"]] = vlan_id
else:
return None
if not isinstance(vlan_id, str):
Expand Down