Skip to content

Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S… - #244

Merged
SuvarnaMeenakshi merged 9 commits into
sonic-net:masterfrom
ysmanman:recirc-port-support
May 4, 2022
Merged

Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S…#244
SuvarnaMeenakshi merged 9 commits into
sonic-net:masterfrom
ysmanman:recirc-port-support

Conversation

@ysmanman

@ysmanman ysmanman commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

…yncD-connected MIB(s)

- What I did

VoQ inband port support was added in #228. This PR is to add support for VoQ recirc port.

This PR depends sonic-net/sonic-py-swsssdk#118, which defines index for VoQ recirc port.

- How I did it

- How to verify it

- Description for the changelog

@arlakshm

arlakshm commented Mar 7, 2022

Copy link
Copy Markdown

/Azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread src/sonic_ax_impl/mibs/__init__.py
@SuvarnaMeenakshi

Copy link
Copy Markdown
Contributor

Can you raise PR to update sub-module to include : sonic-net/sonic-py-swsssdk#118 so that snmpagent build succeeds.

@ysmanman

Copy link
Copy Markdown
Contributor Author

Can you raise PR to update sub-module to include : Azure/sonic-py-swsssdk#118 so that snmpagent build succeeds.

@SuvarnaMeenakshi Thanks for the reminder. Created PR sonic-net/sonic-buildimage#10220

@SuvarnaMeenakshi

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread tests/namespace/test_mibs.py
Comment thread tests/namespace/test_mibs.py
@arlakshm

Copy link
Copy Markdown

/Azp run Azure.sonic-snmpagent

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm

Copy link
Copy Markdown

@ysmanman The test test_init_sync_d_interface_tables_for_recirc_ports is failing. Please take a look

@ysmanman

ysmanman commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

@ysmanman The test test_init_sync_d_interface_tables_for_recirc_ports is failing. Please take a look

@arlakshm I fixed the test and it passed now.

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuvarnaMeenakshi
SuvarnaMeenakshi merged commit 5c08435 into sonic-net:master May 4, 2022
judyjoseph pushed a commit that referenced this pull request May 8, 2022
#244)

- What I did

VoQ inband port support was added in #228. This PR is to add support for VoQ recirc port.

This PR depends sonic-net/sonic-py-swsssdk#118, which defines index for VoQ recirc port.
ssithaia-ebay pushed a commit to ssithaia-ebay/sonic-snmpagent that referenced this pull request May 23, 2025
sonic-net#244)

- What I did

VoQ inband port support was added in sonic-net#228. This PR is to add support for VoQ recirc port.

This PR depends sonic-net/sonic-py-swsssdk#118, which defines index for VoQ recirc port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants