Removed unused variables in rfc2863.py#237
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Oct 26, 2021
Merged
Conversation
Signed-off-by: raphaelt <[email protected]>
qiluo-msft
approved these changes
Oct 26, 2021
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-snmpagent
that referenced
this pull request
Feb 24, 2023
**- What I did** Removed unused variables rif_port_map and port_rif_map in rfc2863.py **- How I did it** Edited rfc2863.py as requested by @qiluo-msft in merged PR sonic-net#218. **- How to verify it** pytest-3 test_interfaces.py and pytest-3 namespace/test_interfaces.py in sonic-snmpagent/tests. **- Description for the changelog** Removed unused variables. (cherry picked from commit a07da53)
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-snmpagent
that referenced
this pull request
Feb 28, 2023
**- What I did** Removed unused variables rif_port_map and port_rif_map in rfc2863.py **- How I did it** Edited rfc2863.py as requested by @qiluo-msft in merged PR sonic-net#218. **- How to verify it** pytest-3 test_interfaces.py and pytest-3 namespace/test_interfaces.py in sonic-snmpagent/tests. **- Description for the changelog** Removed unused variables. (cherry picked from commit a07da53)
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 4, 2023
… for RFC2863 (#279) **- What I did** Cherry-pick the required PRs to 202012 Branch to add SNMP VLAN Support. This is done because the VLAN if index comes in ipNetToMediaPhysAddress (1.3.6.1.2.1.4.22.1.2) but not in ifName 1.3.6.1.2.1.31.1.1.1.1. **- How I did it** Cherry-pick below PRs: #218 - Main change #224 - Follow up PR #237 - Follow up PR **- How to verify it** Before PR changes: ``` admin@str2-sn3800-02:~$ docker exec -it snmp snmpwalk -v2c -c msft 127.0.0.1 1.3.6.1.2.1.31.1.1.1.1 iso.3.6.1.2.1.31.1.1.1.1.1 = STRING: "etp1a" iso.3.6.1.2.1.31.1.1.1.1.3 = STRING: "etp1b" iso.3.6.1.2.1.31.1.1.1.1.5 = STRING: "etp2a" iso.3.6.1.2.1.31.1.1.1.1.7 = STRING: "etp2b" iso.3.6.1.2.1.31.1.1.1.1.9 = STRING: "etp3a" iso.3.6.1.2.1.31.1.1.1.1.11 = STRING: "etp3b" .. iso.3.6.1.2.1.31.1.1.1.1.255 = STRING: "etp64b" iso.3.6.1.2.1.31.1.1.1.1.1101 = STRING: "PortChannel101" iso.3.6.1.2.1.31.1.1.1.1.1102 = STRING: "PortChannel102" iso.3.6.1.2.1.31.1.1.1.1.1103 = STRING: "PortChannel103" iso.3.6.1.2.1.31.1.1.1.1.1104 = STRING: "PortChannel104" iso.3.6.1.2.1.31.1.1.1.1.10000 = STRING: "eth0" ``` After PR changes; Can see vlan 1000 with ifindex3000: ``` admin@str2-sn3800-02:~$ docker exec -it snmp snmpwalk -v2c -c msft 127.0.0.1 1.3.6.1.2.1.31.1.1.1.1 iso.3.6.1.2.1.31.1.1.1.1.1 = STRING: "etp1a" iso.3.6.1.2.1.31.1.1.1.1.3 = STRING: "etp1b" iso.3.6.1.2.1.31.1.1.1.1.5 = STRING: "etp2a" iso.3.6.1.2.1.31.1.1.1.1.7 = STRING: "etp2b" iso.3.6.1.2.1.31.1.1.1.1.9 = STRING: "etp3a" iso.3.6.1.2.1.31.1.1.1.1.11 = STRING: "etp3b" .. iso.3.6.1.2.1.31.1.1.1.1.255 = STRING: "etp64b" iso.3.6.1.2.1.31.1.1.1.1.1101 = STRING: "PortChannel101" iso.3.6.1.2.1.31.1.1.1.1.1102 = STRING: "PortChannel102" iso.3.6.1.2.1.31.1.1.1.1.1103 = STRING: "PortChannel103" iso.3.6.1.2.1.31.1.1.1.1.1104 = STRING: "PortChannel104" iso.3.6.1.2.1.31.1.1.1.1.3000 = STRING: "Vlan1000" iso.3.6.1.2.1.31.1.1.1.1.10000 = STRING: "eth0" ``` UT Passes
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sonic-snmpagent
that referenced
this pull request
May 23, 2025
**- What I did** Removed unused variables rif_port_map and port_rif_map in rfc2863.py **- How I did it** Edited rfc2863.py as requested by @qiluo-msft in merged PR sonic-net#218. **- How to verify it** pytest-3 test_interfaces.py and pytest-3 namespace/test_interfaces.py in sonic-snmpagent/tests. **- Description for the changelog** Removed unused variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: raphaelt [email protected]
- What I did
Removed unused variables rif_port_map and port_rif_map in rfc2863.py
- How I did it
Edited rfc2863.py as requested by @qiluo-msft in merged PR #218.
- How to verify it
pytest-3 test_interfaces.py and pytest-3 namespace/test_interfaces.py in sonic-snmpagent/tests.
- Description for the changelog
Removed unused variables.