Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code#162
Merged
qiluo-msft merged 7 commits intosonic-net:masterfrom Nov 6, 2020
Conversation
9 tasks
Contributor
Author
|
retest this please |
qiluo-msft
force-pushed
the
qiluo/mergecommon2
branch
2 times, most recently
from
b682de5 to
4b015cb
Compare
non-testing code Signed-off-by: Qi Luo <[email protected]>
This reverts commit 1000c37.
qiluo-msft
force-pushed
the
qiluo/mergecommon2
branch
from
4b015cb to
0a882e5
Compare
qiluo-msft
changed the title
tests/mock_tables/dbconnector.py
Outdated
| mockredis.MockRedis.config_set = config_set | ||
| redis.StrictRedis = SwssSyncClient | ||
| SonicV2Connector.connect = connect_SonicV2Connector | ||
| swsssdk.SonicV2Connector = SonicV2Connector |
Contributor
There was a problem hiding this comment.
Why is this required? Isn't SonicV2Connector already swsssdk.SonicV2Connector? #Resolved
Contributor
Author
There was a problem hiding this comment.
Fix kwargs.pop() if there is no argument provided
SuvarnaMeenakshi
approved these changes
Nov 5, 2020
ssithaia-ebay
pushed a commit
to ssithaia-ebay/sonic-snmpagent
that referenced
this pull request
May 23, 2025
…IG wrapper of C++ implementation) in production code (sonic-net#162) This is the following step for merging sonic-py-swsssdk into sonic-swss-common sonic-net/sonic-swss-common#387 Note: Test code could still using old python implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the following step for merging sonic-py-swsssdk into sonic-swss-common sonic-net/sonic-swss-common#387
Please merge after sonic-swss-common sonic-net/sonic-swss-common#387 merged
Please merge after sonic-swss-common sonic-net/sonic-swss-common#401 merged
Note: Test code could still using old python implementation