Skip to content

[pipeline] Download swss common artifact in a separated directory#995

Merged
jimmyzhai merged 2 commits intosonic-net:masterfrom
jimmyzhai:pipeline
Jan 24, 2022
Merged

[pipeline] Download swss common artifact in a separated directory#995
jimmyzhai merged 2 commits intosonic-net:masterfrom
jimmyzhai:pipeline

Conversation

@jimmyzhai
Copy link
Contributor

@jimmyzhai jimmyzhai commented Jan 21, 2022

  • Put the downloaded swss common artifact in a separated directory while build sairedis target.
  • The downloaded swss common artifact is in a sub-directory of sairedis artifact, then it avoids overriding
    the previous swss common packages.

cd $(Build.SourcesDirectory)/${{ parameters.swss_common_artifact_name }}
sudo dpkg -i libswsscommon_1.0.0_${{ parameters.arch }}.deb
sudo dpkg -i libswsscommon-dev_1.0.0_${{ parameters.arch }}.deb
workingDirectory: $(Pipeline.Workspace)
Copy link
Collaborator

@xumia xumia Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the workDirectroy to $(Build.SourcesDirectory)/${{ parameters.swss_common_artifact_name }}, so do not need to change directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I move the step of sairedis checkout to the first.

xumia
xumia previously approved these changes Jan 21, 2022
@qiluo-msft
Copy link
Contributor

The sonic-sairedis artifact will not include the downloaded swss common artifact, otherwise its using
may have issue of overriding the previous swss common packages.

Then in the artifacts view, we have no way to check libswsscommon packages. This will possible limit our observation and the troubleshooting capability.

@jimmyzhai
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai jimmyzhai merged commit 1b8ce97 into sonic-net:master Jan 24, 2022
qiluo-msft pushed a commit to sonic-net/sonic-swss-common that referenced this pull request Jan 25, 2022
…d database ID (#568)" (#574)" (#578)

Reverts #574

The real cause is fixed at sonic-net/sonic-sairedis#995. Continue to commit bd4d0ce again.
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
…nic-net#995)

* Put the downloaded swss common artifact in a separated directory while build sairedis target.
* The downloaded swss common artifact is in a sub-directory of sairedis artifact, then it avoids
   overriding the previous swss common packages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants