Skip to content

Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kcudnik merged 4 commits into from
Aug 26, 2021
Merged

Change the log severity leve from ERROR to NOTICE if getStatus is not supported by vendor #908

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
458a46f
Change the log severity leve from ERROR to NOTICE if getStatus is not…
stephenxs Aug 25, 2021
55534ab
Fix review comments
stephenxs Aug 26, 2021
d607fe8
Fix review comments
stephenxs Aug 26, 2021
567d580
Add error code
stephenxs Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions syncd/Syncd.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,9 +706,14 @@ sai_status_t Syncd::processGetStatsEvent(

std::vector<swss::FieldValueTuple> entry;

if (status != SAI_STATUS_SUCCESS)
if (SAI_STATUS_IS_ATTR_NOT_SUPPORTED(status) || SAI_STATUS_IS_ATTR_NOT_IMPLEMENTED(status)
|| status == SAI_STATUS_NOT_SUPPORTED || status == SAI_STATUS_NOT_IMPLEMENTED)
{
SWSS_LOG_NOTICE("Getting stats on %s is not supported on the platform", key.c_str());
}
else if (status != SAI_STATUS_SUCCESS)
{
SWSS_LOG_ERROR("Failed to get stats");
SWSS_LOG_NOTICE("Getting stats error");
}
else
{
Expand Down