Skip to content

[syncd] Clean up log messages and add performance timer for bulk route create#864

Merged
kcudnik merged 3 commits intosonic-net:masterfrom
kcudnik:timer
Jul 21, 2021
Merged

[syncd] Clean up log messages and add performance timer for bulk route create#864
kcudnik merged 3 commits intosonic-net:masterfrom
kcudnik:timer

Conversation

@kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented Jul 16, 2021

No description provided.

entries[it].vr_id = m_translator->translateVidToRid(entries[it].vr_id);
}

static PerformanceIntervalTimer timer("Syncd::processBulkCreateEntry(route_entry) CREATE");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static

Better to use class static member. There could be multiple Syncd instances, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per process, no, i will fix that on the road, so far here are many performance counters instantiated like here

@kcudnik kcudnik merged commit ab80b0e into sonic-net:master Jul 21, 2021
@kcudnik kcudnik deleted the timer branch July 21, 2021 09:45
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants