Fix serialization and refactor virtual switch init logic#85
Merged
kcudnik merged 3 commits intosonic-net:masterfrom Oct 13, 2016
Merged
Fix serialization and refactor virtual switch init logic#85kcudnik merged 3 commits intosonic-net:masterfrom
kcudnik merged 3 commits intosonic-net:masterfrom
Conversation
qiluo-msft
requested changes
Oct 11, 2016
vslib/src/sai_vs_generic_create.cpp
Outdated
| { | ||
| SWSS_LOG_ENTER(); | ||
|
|
||
| std::string otstr; |
qiluo-msft
requested changes
Oct 11, 2016
| { | ||
| auto it = vlan_members_map[vlan_id].find(vlan_member_id); | ||
|
|
||
| vlan_members_map[vlan_id].erase(it); |
Contributor
There was a problem hiding this comment.
Will it be set::end? If never, add assertion?
Collaborator
Author
There was a problem hiding this comment.
no, as you can se its only executed after success, so vlan member id will exists
stcheng
reviewed
Oct 12, 2016
| std::string lane_str; | ||
| std::set<int> lane_set; | ||
|
|
Contributor
There was a problem hiding this comment.
you could use tokenize() function in swss-common
stcheng
reviewed
Oct 12, 2016
|
|
||
| vlan_members_map[DEFAULT_VLAN_NUMBER] = {}; | ||
|
|
||
| for (auto &port_id : port_list) |
Contributor
There was a problem hiding this comment.
i doubt if we will add this to vs behavior. default vlan 1 needs to be there, but we could have 0 members in the default vlan. the behavior of adding all ports into default vlan by default is optional.
Collaborator
Author
There was a problem hiding this comment.
This is virtual switch, we decide what behavior is, also metadata will not allow removing vlan 1
qiluo-msft
approved these changes
Oct 12, 2016
DavidZagury
pushed a commit
to DavidZagury/sonic-sairedis
that referenced
this pull request
Dec 6, 2025
… class (sonic-net#85) Signed-off-by: Stephen Sun <stephens@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.