[syncd] Fix bulk multi attrs for same key db update#761
Merged
kcudnik merged 2 commits intosonic-net:masterfrom Jan 5, 2021
Merged
[syncd] Fix bulk multi attrs for same key db update#761kcudnik merged 2 commits intosonic-net:masterfrom
kcudnik merged 2 commits intosonic-net:masterfrom
Conversation
yxieca
previously approved these changes
Jan 4, 2021
lguohan
reviewed
Jan 4, 2021
syncd/Syncd.cpp
Outdated
| if (api == SAI_COMMON_API_BULK_SET) | ||
| { | ||
| // in case of bulk set operation, it can happen that multiple | ||
| // attributes will be set for the same key, then wehen we want to |
Contributor
|
wonder if you add more description on the commit? |
Collaborator
Author
|
done |
shi-su
approved these changes
Jan 4, 2021
Collaborator
Author
|
retest vs please |
Collaborator
Author
|
@lguohan should all vs tests pass? in previous PR you mentioned that 4 tests are fine ? |
Contributor
|
yes, if you see 4 tests failing, then it means this pr is ok. the four failed test cases are known issue. |
yxieca
approved these changes
Jan 5, 2021
Contributor
|
retest this please |
Collaborator
Author
|
merging, since expected 4 tests failed |
4 tasks
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
issue was related to bulk set operation, when multiple attributes were set for the same key, in this case bug was causing that only last attribute was actually written to database and previous ones were skipped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attributes will be set for the same key, then when we want to, push them to redis database, we need to combine all attributes, to a single vector of attributes
issue was related to bulk set operation, when multiple attributes were set for the same key, in this case bug was causing that only last attribute was actually written to database and previous ones were skipped