[meta] Use memcpy instead of cast to prevent strict-aliasing error#723
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Dec 1, 2020
Merged
[meta] Use memcpy instead of cast to prevent strict-aliasing error#723kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
Author
|
hope will fix sonic-net/sonic-buildimage#6064 |
Collaborator
Author
|
retest vs please |
qiluo-msft
reviewed
Dec 1, 2020
| return ne.ip_address.addr_family; | ||
| } | ||
|
|
||
| static_assert(sizeof(uint32_t) == 4, "uint32_t expected to be 4 bytes"); |
Contributor
There was a problem hiding this comment.
static_assert [](start = 0, length = 13)
This assertion seems not needed. Do you anticipate some failure case?
Collaborator
Author
There was a problem hiding this comment.
just a surprise for some wired platforms :D
qiluo-msft
approved these changes
Dec 1, 2020
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.