Skip to content

Fixing classical if (x==y) bug introduced while cherry-pick merging#606

Merged
kcudnik merged 2 commits intosonic-net:201911from
vasant17:BUG_FIX_CHERRY_PICK
Apr 16, 2020
Merged

Fixing classical if (x==y) bug introduced while cherry-pick merging#606
kcudnik merged 2 commits intosonic-net:201911from
vasant17:BUG_FIX_CHERRY_PICK

Conversation

@vasant17
Copy link
Contributor

No description provided.

@lguohan lguohan requested a review from kcudnik April 16, 2020 08:14
@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2020

This pull request fixes 1 alert when merging 8ad8b0e into 20ffeea - view on LGTM.com

fixed alerts:

  • 1 for Assignment where comparison was intended

@lguohan lguohan added the Bug label Apr 16, 2020
@kcudnik kcudnik merged commit 0305b7f into sonic-net:201911 Apr 16, 2020
vasant17 added a commit to vasant17/sonic-sairedis that referenced this pull request Apr 16, 2020
…onic-net#606)

* Fixing classical if (x==y) bug introduced while cherry-pick merging

* Addressed code-review comments

Co-authored-by: Vasant <[email protected]>
zhenggen-xu pushed a commit to zhenggen-xu/sonic-sairedis that referenced this pull request Apr 16, 2020
…onic-net#606) (#6)

* Fixing classical if (x==y) bug introduced while cherry-pick merging

* Addressed code-review comments

Co-authored-by: Vasant <[email protected]>

Co-authored-by: Vasant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants