acquire lock before accessing shared redis context#489
Merged
kcudnik merged 12 commits intosonic-net:masterfrom Jul 24, 2019
Merged
acquire lock before accessing shared redis context#489kcudnik merged 12 commits intosonic-net:masterfrom
kcudnik merged 12 commits intosonic-net:masterfrom
Conversation
…d access from different threads syncd main thread was doing g_redisClient->hget without acquiring g_mutex, thereby causing either syncd main thread or notification thread to block indefinitely on redisBufferRead().
kcudnik
approved these changes
Jul 19, 2019
Contributor
|
@anilkpandey, can you resolve the conflict? |
Contributor
Author
I am not able to, may be because I don't have write access. |
Contributor
|
You can merge/rebase from master and push to this PR. You don't have to use the resolve button above. |
Contributor
|
Looks like the editor added a lot of tab spaces. Kindly revert the space changes and recommit. |
Contributor
Author
Done |
lguohan
approved these changes
Jul 21, 2019
wendani
approved these changes
Jul 23, 2019
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* fixed issue of permenent block on redisBufferRead() due to unprotected access from different threads syncd main thread was doing g_redisClient->hget without acquiring g_mutex, thereby causing either syncd main thread or notification thread to block indefinitely on redisBufferRead(). * Delete .DS_Store . * resolved merge conflict * Revert "resolved merge conflict" This reverts commit f009491. * Revert "Merge remote-tracking branch 'upstream/master'" This reverts commit 550aca9, reversing changes made to 676c0b5. * Revert "Revert "Merge remote-tracking branch 'upstream/master'"" This reverts commit 03fc996. * Revert "Revert "resolved merge conflict"" This reverts commit e840a6b. * Update syncd.cpp * Update syncd.cpp * Update syncd.cpp * Update syncd.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple threads in syncd access ASIC_DB through the same redis context. g_mutex is used to synchronize the access as hiredis is not thread safe.
Function try_translate_vid_to_rid(), which accesses ASIC_DB was being called unprotected. This caused one of the threads to stuck on redisBufferRead().
(gdb) bt
#0 0x00007f15301cd22d in read () from /lib/x86_64-linux-gnu/libpthread.so.0
#1 0x00007f1537ebf6a2 in read (__nbytes=16384, __buf=0x7f152d6b0910,
__fd=) at /usr/include/x86_64-linux-gnu/bits/unistd.h:44
#2 redisBufferRead (c=0x55c450ffdde0) at hiredis.c:802
#3 0x00007f1537ebf9a0 in redisGetReply (c=0x55c450ffdde0,
reply=reply@entry=0x7f152d6b4a00) at hiredis.c:888
#4 0x00007f1537c612d0 in swss::RedisReply::RedisReply (this=0x7f152d6b4a00,
db=0x55c451001e80, command=...) at redisreply.cpp:33
#5 0x00007f1537c614c2 in swss::RedisReply::RedisReply (this=0x7f152d6b4a00,
db=, command=..., expectedType=3) at redisreply.cpp:45
#6 0x00007f1537c7efba in swss::RedisClient::hset (this=0x55c450ffd510,
key="ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{"bvid":"oid:0x26000000000e17","mac":"3C:2C:99:8B:35:BC","switch_id":"oid:0x21", '0' <repeats 12 times>, ""}", field="SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID",
value="oid:0x3a00000000104d") at redisclient.cpp:56