Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/src/sai_redis_fdb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ sai_status_t internal_redis_flush_fdb_entries(

swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd, GET_RESPONSE_TIMEOUT);
int result = s.select(&sel, GET_RESPONSE_TIMEOUT);

if (result == swss::Select::OBJECT)
{
Expand Down
8 changes: 1 addition & 7 deletions lib/src/sai_redis_generic_get.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ std::string getSelectResultAsString(int result)

switch (result)
{
case swss::Select::FD:
res = "FD";
break;

case swss::Select::ERROR:
res = "ERROR";
break;
Expand Down Expand Up @@ -198,9 +194,7 @@ sai_status_t internal_redis_generic_get(

swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd, GET_RESPONSE_TIMEOUT);
int result = s.select(&sel, GET_RESPONSE_TIMEOUT);

if (result == swss::Select::OBJECT)
{
Expand Down
4 changes: 1 addition & 3 deletions lib/src/sai_redis_generic_get_stats.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,7 @@ sai_status_t internal_redis_generic_get_stats(

swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd, GET_RESPONSE_TIMEOUT);
int result = s.select(&sel, GET_RESPONSE_TIMEOUT);

if (result == swss::Select::OBJECT)
{
Expand Down
4 changes: 1 addition & 3 deletions lib/src/sai_redis_interfacequery.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,7 @@ void ntf_thread()
{
swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd);
int result = s.select(&sel);

if (sel == &g_redisNotificationTrheadEvent)
{
Expand Down
4 changes: 1 addition & 3 deletions lib/src/sai_redis_switch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ sai_status_t sai_redis_internal_notify_syncd(

swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd, GET_RESPONSE_TIMEOUT);
int result = s.select(&sel, GET_RESPONSE_TIMEOUT);

if (result == swss::Select::OBJECT)
{
Expand Down
4 changes: 1 addition & 3 deletions syncd/syncd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3358,9 +3358,7 @@ int syncd_main(int argc, char **argv)
{
swss::Selectable *sel = NULL;

int fd;

int result = s.select(&sel, &fd);
int result = s.select(&sel);

if (sel == restartQuery.get())
{
Expand Down
3 changes: 1 addition & 2 deletions syncd/tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -156,11 +156,10 @@ void bulk_nhgm_consumer_worker()
swss::ConsumerTable c(&db, tableName);
swss::Select cs;
swss::Selectable *selectcs;
int tmpfd;
int ret = 0;

cs.addSelectable(&c);
while ((ret = cs.select(&selectcs, &tmpfd)) == swss::Select::OBJECT)
while ((ret = cs.select(&selectcs)) == swss::Select::OBJECT)
{
swss::KeyOpFieldsValuesTuple kco;
c.pop(kco);
Expand Down
4 changes: 1 addition & 3 deletions vslib/src/sai_vs_interfacequery.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,7 @@ void unittestChannelThreadProc()
{
swss::Selectable *sel;

int fd;

int result = s.select(&sel, &fd);
int result = s.select(&sel);

if (sel == &g_unittestChannelThreadEvent)
{
Expand Down
3 changes: 1 addition & 2 deletions vslib/src/sai_vs_switch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,7 @@ void linkmsg_thread(
{
swss::Selectable *temps = NULL;

int tempfd;
int result = s.select(&temps, &tempfd);
int result = s.select(&temps);

SWSS_LOG_INFO("select ended: %d", result);
}
Expand Down