Skip to content

Added SAI dump support to syncd#199

Merged
kcudnik merged 3 commits intosonic-net:v1.0.3from
andrii-savka:saidump
Jul 31, 2017
Merged

Added SAI dump support to syncd#199
kcudnik merged 3 commits intosonic-net:v1.0.3from
andrii-savka:saidump

Conversation

@andrii-savka
Copy link
Copy Markdown

No description provided.

@msftclas
Copy link
Copy Markdown

@andrii-savka,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link
Copy Markdown

@andrii-savka, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Jul 21, 2017

What is purpose of this change? there is already saidump tool which dumps redis database to file

@andrii-savka
Copy link
Copy Markdown
Author

To @kcudnik
The purpose of this change is to dump the real SAI state including SDK log.
The "saidump" tool dumps only the sairedis database - not a SAI layer and it could be different.
It is new feature introduced for dumping the SAI and SDK log and add them to sysdump.

@kcudnik
Copy link
Copy Markdown
Collaborator

kcudnik commented Jul 24, 2017

This could be done easier if you would use connect to existign sai with INIT == false, similar like saidiscovery tool

@kcudnik kcudnik merged commit 269f0b7 into sonic-net:v1.0.3 Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants