[DPU] Add support for Flow bulk session get notifications by vivekrnv · Pull Request #1769 · sonic-net/sonic-sairedis

vivekrnv · 2026-02-14T00:54:13Z

Add support for Flow Bulk Session get notification
Flow Dump events are directly written to a file from syncd and not relayed to orchgent
Only FINISHED_EVENT's are relayed to orchagent
Add UT's and verified by creating session events

Note: Google Test filter = *Flow*
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from NotificationFlowBulkGetSessionEvent
[ RUN      ] NotificationFlowBulkGetSessionEvent.ctr
[       OK ] NotificationFlowBulkGetSessionEvent.ctr (0 ms)
[ RUN      ] NotificationFlowBulkGetSessionEvent.getSwitchId
[       OK ] NotificationFlowBulkGetSessionEvent.getSwitchId (0 ms)
[ RUN      ] NotificationFlowBulkGetSessionEvent.getAnyObjectId
[       OK ] NotificationFlowBulkGetSessionEvent.getAnyObjectId (0 ms)
[ RUN      ] NotificationFlowBulkGetSessionEvent.processMetadata
[       OK ] NotificationFlowBulkGetSessionEvent.processMetadata (0 ms)
[ RUN      ] NotificationFlowBulkGetSessionEvent.executeCallback
[       OK ] NotificationFlowBulkGetSessionEvent.executeCallback (0 ms)
[----------] 5 tests from NotificationFlowBulkGetSessionEvent (0 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 5 tests.

vkarri@300929d3c803:/sonic/src/sonic-sairedis/unittest/syncd$ ./tests --gtest_filter="*Flow*"
Note: Google Test filter = *Flow*
[==========] Running 15 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from NotificationHandler
[ RUN      ] NotificationHandler.NotificationFlowBulkGetSessionEventTest
[       OK ] NotificationHandler.NotificationFlowBulkGetSessionEventTest (0 ms)
[----------] 1 test from NotificationHandler (0 ms total)

[----------] 14 tests from FlowDumpTest
[ RUN      ] FlowDumpTest.FlowDumpSerializer_SingleFlowEntry
[       OK ] FlowDumpTest.FlowDumpSerializer_SingleFlowEntry (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_MultipleFlowEntries
[       OK ] FlowDumpTest.FlowDumpSerializer_MultipleFlowEntries (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_FinishedEvent
[       OK ] FlowDumpTest.FlowDumpSerializer_FinishedEvent (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_WithAttributes
[       OK ] FlowDumpTest.FlowDumpSerializer_WithAttributes (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_WriteAndRead
[       OK ] FlowDumpTest.FlowDumpWriter_WriteAndRead (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_FilePathGeneration
[       OK ] FlowDumpTest.FlowDumpWriter_FilePathGeneration (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_BasePathGetterSetter
[       OK ] FlowDumpTest.FlowDumpWriter_BasePathGetterSetter (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_NullData
[       OK ] FlowDumpTest.FlowDumpWriter_NullData (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_MultipleFlows
[       OK ] FlowDumpTest.FlowDumpWriter_MultipleFlows (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_WithAttributes
[       OK ] FlowDumpTest.FlowDumpWriter_WithAttributes (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpWriter_LogRotate
[       OK ] FlowDumpTest.FlowDumpWriter_LogRotate (201 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_AttributeValue_EnumTypes
[       OK ] FlowDumpTest.FlowDumpSerializer_AttributeValue_EnumTypes (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_AttributeValue_U8List
[       OK ] FlowDumpTest.FlowDumpSerializer_AttributeValue_U8List (0 ms)
[ RUN      ] FlowDumpTest.FlowDumpSerializer_AttributeValue_ExceptionHandling
[       OK ] FlowDumpTest.FlowDumpSerializer_AttributeValue_ExceptionHandling (0 ms)
[----------] 14 tests from FlowDumpTest (203 ms total)

[----------] Global test environment tear-down
[==========] 15 tests from 2 test suites ran. (203 ms total)
[  PASSED  ] 15 tests.

mssonicbld · 2026-02-14T00:54:21Z

/azp run

azure-pipelines · 2026-02-14T00:54:32Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-14T01:02:56Z

/azp run

azure-pipelines · 2026-02-14T01:03:07Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

This pull request adds support for Flow Bulk Session get notifications in the DPU (Data Processing Unit) pipeline. The implementation introduces a new mechanism where flow dump events are written directly to compressed files from syncd, while only FINISHED events are relayed to orchagent for notification. This design improves performance by avoiding the overhead of serializing and transmitting large amounts of flow data through Redis.

Changes:

Added flow dump infrastructure with JSON serialization and gzip compression for efficient storage
Implemented notification filtering logic to write flow entries to disk while only forwarding FINISHED events
Extended notification queue to support auxiliary data (flow dump JSON lines) alongside standard notifications
Added comprehensive unit tests covering serialization, file I/O, log rotation, and notification handling

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
syncd/FlowDump.{h,cpp}	Core flow dump serialization and file writing logic with log rotation
syncd/NotificationHandler.{h,cpp}	Collects flow entry events and enqueues with auxiliary data
syncd/NotificationProcessor.{h,cpp}	Processes flow notifications, writes dumps to disk, filters FINISHED events
syncd/NotificationQueue.{h,cpp}	Extended to support auxiliary data alongside notifications
syncd/SwitchNotifications.{h,cpp}	Added callback registration for flow bulk get session events
meta/NotificationFlowBulkGetSessionEvent.{h,cpp}	Notification class for flow bulk get session events
meta/Meta.{h,cpp}	Validation logic for flow bulk get session event notifications
meta/SaiSerialize.cpp	Serialization/deserialization for flow bulk get session event notifications
vslib/SwitchStateBase.cpp	Registered flow bulk get session event notification in virtual switch
unittest/syncd/TestFlowDump.cpp	Comprehensive tests for serialization, file I/O, and log rotation
unittest/syncd/TestNotificationHandler.cpp	Tests for notification handler with flow events
unittest/meta/TestSaiSerialize.cpp	Tests for serialization/deserialization logic
proxylib/Proxy.{h,cpp}	Proxy notification forwarding support
saiplayer/SaiPlayer.{h,cpp}	Player notification handling support
pyext/pysairedis.{i,cpp}	Python bindings for flow bulk get session events
*/Makefile.am	Added -lz linker flag for zlib compression support

syncd/NotificationProcessor.cpp

unittest/syncd/TestFlowDump.cpp

syncd/FlowDump.cpp

meta/SaiSerialize.cpp

unittest/meta/TestSaiSerialize.cpp

syncd/FlowDump.cpp

syncd/NotificationProcessor.cpp

mssonicbld · 2026-02-14T08:29:21Z

/azp run

azure-pipelines · 2026-02-14T08:29:32Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-17T21:16:02Z

/azp run

azure-pipelines · 2026-02-17T21:16:14Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-17T22:27:27Z

/azp run

azure-pipelines · 2026-02-17T22:27:38Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-18T02:06:46Z

/azp run

azure-pipelines · 2026-02-18T02:06:57Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-18T02:09:07Z

/azp run

azure-pipelines · 2026-02-18T02:09:20Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-18T02:09:46Z

/azp run

azure-pipelines · 2026-02-18T02:09:56Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-18T02:10:11Z

/azp run

azure-pipelines · 2026-02-18T02:10:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Vivek Reddy <[email protected]>

…#1757) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

why currently vpp doesn't support binding multiple ACL tables. Each table is appended with default permit-all rules. With multiple tables, this may cause acl matched by such rules and skip the actual rule to make in the tables after this one. what this PR does remove the default permit-all rules for each table If a table is empty, create a dummy rule that won't match any traffic because vpp doesn't allow empty table. The dummy rule matches dest-ip to 0.0.0.0/32 sort all the tables by priority in the table group. vpp doesn't support parallel matching added catch-all acl group to the end. vpp default behavior of no match is drop but sonic is accept. Fix sonic-vpp crashing due to race condition during stats pull. If the interface to get stats has been removed, stat_segment_ls_r returns null. Signed-off-by: Yue Gao <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

Co-authored-by: Copilot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

mssonicbld · 2026-02-18T02:18:47Z

/azp run

azure-pipelines · 2026-02-18T02:18:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Vivek Reddy <[email protected]>

mssonicbld · 2026-02-18T02:30:41Z

/azp run

azure-pipelines · 2026-02-18T02:30:51Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-18T02:50:04Z

/azp run

azure-pipelines · 2026-02-18T02:50:15Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2026-02-19T15:49:25Z

/azpw run Azure.sonic-sairedis

mssonicbld · 2026-02-19T15:49:28Z

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines · 2026-02-19T15:49:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-02-24T20:51:08Z

/azp run

azure-pipelines · 2026-02-24T20:51:20Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2026-03-02T21:24:04Z

@saiarcot895 , can you check and merge the PR?

mssonicbld · 2026-03-05T16:21:23Z

/azp run

azure-pipelines · 2026-03-05T16:21:38Z

Azure Pipelines successfully started running 1 pipeline(s).

vivekrnv · 2026-03-05T19:12:36Z

@lihuay Can you merge the changes?

vivekrnv mentioned this pull request Feb 14, 2026

[DPU] [HA] Add support for Flow API sonic-net/sonic-swss#4218

Open

vivekrnv marked this pull request as ready for review February 14, 2026 00:59

lguohan requested a review from Copilot February 14, 2026 06:12

Copilot started reviewing on behalf of lguohan February 14, 2026 06:13 View session

Copilot AI reviewed Feb 14, 2026

View reviewed changes

vivekrnv force-pushed the bulk_get_sess_notif branch from 6cf5250 to 3aa0222 Compare February 14, 2026 08:29

vivekrnv and others added 6 commits February 18, 2026 04:18

[DPU] Add support for Flow bulk session get notifications

e32bf1f

Signed-off-by: Vivek Reddy <[email protected]>

Remove obvious comments

06842ea

Signed-off-by: Vivek Reddy <[email protected]>

Add processMetadata method to validate object id

b2c6cce

Signed-off-by: Vivek Reddy <[email protected]>

Handled comments

8f98128

Signed-off-by: Vivek Reddy <[email protected]>

Minor fixes

d00fba6

Signed-off-by: Vivek Reddy <[email protected]>

Use get_stats_ext instead of get_stats for switch counters (sonic-net…

a59de86

…#1757) Signed-off-by: Ryan Garofano <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

yue-fred-gao and others added 5 commits February 18, 2026 04:18

Update syncd/NotificationProcessor.cpp

6ffe4f6

Co-authored-by: Copilot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

Update syncd/FlowDump.cpp

4b84924

Co-authored-by: Copilot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

Update syncd/FlowDump.cpp

6b5e6ae

Co-authored-by: Copilot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

Update meta/SaiSerialize.cpp

0aaee63

Co-authored-by: Copilot <[email protected]> Signed-off-by: Vivek Reddy <[email protected]>

vivekrnv force-pushed the bulk_get_sess_notif branch from ff1ea46 to 0aaee63 Compare February 18, 2026 02:18

Handle co-pilot comments

98f8828

Signed-off-by: Vivek Reddy <[email protected]>

Merge branch 'master' into bulk_get_sess_notif

114b525

dgsudharsan approved these changes Feb 18, 2026

View reviewed changes

vivekrnv mentioned this pull request Feb 18, 2026

[smart switch] Add Flow Dump to HA HLD sonic-net/SONiC#2168

Open

Merge branch 'master' into bulk_get_sess_notif

29be3dd

zjswhhh approved these changes Mar 2, 2026

View reviewed changes

prsunny approved these changes Mar 2, 2026

View reviewed changes

Merge branch 'master' into bulk_get_sess_notif

9fd7b4c

lihuay merged commit 3679821 into sonic-net:master Mar 5, 2026
19 checks passed

Conversation

vivekrnv commented Feb 14, 2026

Uh oh!

mssonicbld commented Feb 14, 2026

Uh oh!

azure-pipelines bot commented Feb 14, 2026

Uh oh!

mssonicbld commented Feb 14, 2026

Uh oh!

azure-pipelines bot commented Feb 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Feb 14, 2026

Uh oh!

azure-pipelines bot commented Feb 14, 2026

Uh oh!

mssonicbld commented Feb 17, 2026

Uh oh!

azure-pipelines bot commented Feb 17, 2026

Uh oh!

mssonicbld commented Feb 17, 2026

Uh oh!

azure-pipelines bot commented Feb 17, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

mssonicbld commented Feb 18, 2026

Uh oh!

azure-pipelines bot commented Feb 18, 2026

Uh oh!

vivekrnv commented Feb 19, 2026

Uh oh!

mssonicbld commented Feb 19, 2026

Uh oh!

azure-pipelines bot commented Feb 19, 2026

Uh oh!

mssonicbld commented Feb 24, 2026

Uh oh!

azure-pipelines bot commented Feb 24, 2026

Uh oh!

prsunny commented Mar 2, 2026

Uh oh!

mssonicbld commented Mar 5, 2026

Uh oh!

azure-pipelines bot commented Mar 5, 2026

Uh oh!