vpp: support ACL attached to LAG and UDP in ACE#1718
Merged
yue-fred-gao merged 11 commits intosonic-net:masterfrom Dec 19, 2025
Merged
vpp: support ACL attached to LAG and UDP in ACE#1718yue-fred-gao merged 11 commits intosonic-net:masterfrom
yue-fred-gao merged 11 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: Yue Gao <yuega2@cisco.com>
- if protocol is not specified but port or port-range is create 2 rules with proto UDP and TCP. vpp requires proto to be set if port or port-range is used Signed-off-by: Yue Gao <yuega2@cisco.com>
Signed-off-by: Yue Gao <yuega2@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yue Gao <yuega2@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Yue Gao <yuega2@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dypet
reviewed
Dec 10, 2025
| return set_internal(SAI_OBJECT_TYPE_PORT, sid, attr); | ||
| } | ||
|
|
||
| sai_status_t SwitchVpp::setLag( |
Contributor
Author
There was a problem hiding this comment.
The function handles set on LAG object. ACL is only one of the attributes so we shouldn't change it to setLagAcl.
Signed-off-by: Yue Gao <yuega2@cisco.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dypet
approved these changes
Dec 11, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
reviewed
Dec 15, 2025
Contributor
lolyu
left a comment
lolyu
left a comment
There was a problem hiding this comment.
Hi @yue-fred-gao, could you please provide any HLD here or the vpp project progress if possible?
Thanks
Contributor
Author
Hi @lolyu , you can find sonic-vpp HLD at here: https://github.com/sonic-net/sonic-platform-vpp/blob/master/docs/HLD/SONICVPP-HLD.md. In the same directory, you can find other HLDs as well. If you are interested, you are welcome to join the working group: https://lists.sonicfoundation.dev/g/virtual-data-plane. We have weekly meetings, where you can find the latest update. Thanks! |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@saiarcot895 and @lolyu , can you please review the PR? I need one approval with write access. |
saiarcot895
approved these changes
Dec 17, 2025
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
croos12
pushed a commit
to croos12/sonic-sairedis
that referenced
this pull request
Jan 14, 2026
* Handle acl attachment through LAG update * Add default permit-all rules * Support ACL with UDP protocol * if protocol is not specified but port or port-range is create 2 rules with proto UDP and TCP. vpp requires proto to be set if port or port-range is used * realign ace stats index because each ace can map to multiple acl rules Signed-off-by: Yue Gao <yuega2@cisco.com>
yue-fred-gao
added a commit
to yue-fred-gao/sonic-sairedis
that referenced
this pull request
Mar 3, 2026
* Handle acl attachment through LAG update * Add default permit-all rules * Support ACL with UDP protocol * if protocol is not specified but port or port-range is create 2 rules with proto UDP and TCP. vpp requires proto to be set if port or port-range is used * realign ace stats index because each ace can map to multiple acl rules Signed-off-by: Yue Gao <yuega2@cisco.com>
yue-fred-gao
added a commit
that referenced
this pull request
Mar 3, 2026
* Handle acl attachment through LAG update * Add default permit-all rules * Support ACL with UDP protocol * if protocol is not specified but port or port-range is create 2 rules with proto UDP and TCP. vpp requires proto to be set if port or port-range is used * realign ace stats index because each ace can map to multiple acl rules Signed-off-by: Yue Gao <yuega2@cisco.com>
vmittal-msft
pushed a commit
that referenced
this pull request
Mar 9, 2026
* Support for sonic-mgmt ACL testing on VPP (#1599) * Enabling sonic-mgmt ACL testing for Sonic-VPP * Use retval in debugs * Graceful shutdown vpp to avoid core dump (#1714) Signed-off-by: Yue Gao <yuega2@cisco.com> * vpp: support ACL attached to LAG and UDP in ACE (#1718) * Handle acl attachment through LAG update * Add default permit-all rules * Support ACL with UDP protocol * if protocol is not specified but port or port-range is create 2 rules with proto UDP and TCP. vpp requires proto to be set if port or port-range is used * realign ace stats index because each ace can map to multiple acl rules Signed-off-by: Yue Gao <yuega2@cisco.com> * vpp: support binding multiple ACL tables by priority (#1732) why currently vpp doesn't support binding multiple ACL tables. Each table is appended with default permit-all rules. With multiple tables, this may cause acl matched by such rules and skip the actual rule to make in the tables after this one. what this PR does remove the default permit-all rules for each table If a table is empty, create a dummy rule that won't match any traffic because vpp doesn't allow empty table. The dummy rule matches dest-ip to 0.0.0.0/32 sort all the tables by priority in the table group. vpp doesn't support parallel matching added catch-all acl group to the end. vpp default behavior of no match is drop but sonic is accept. Fix sonic-vpp crashing due to race condition during stats pull. If the interface to get stats has been removed, stat_segment_ls_r returns null. Signed-off-by: Yue Gao <yuega2@cisco.com> * changes for vpp release 202510 --------- Signed-off-by: Yue Gao <yuega2@cisco.com> Co-authored-by: AkeelAli <701916+AkeelAli@users.noreply.github.com> Co-authored-by: Mihut Aronovici <aronovic@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
what this PR does