[trim]: Add Packet Trimming Asym DSCP to VS lib#1610
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Jul 3, 2025
Merged
[trim]: Add Packet Trimming Asym DSCP to VS lib#1610kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
requested review from
dgsudharsan,
keboliu,
kperumalbfn,
liat-grozovik,
moshemos,
r12f and
volodymyrsamotiy
This was referenced Jun 12, 2025
nazariig
force-pushed
the
master-trim-asym
branch
from
8e61991 to
c6d3a61
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-trim-asym
branch
from
c6d3a61 to
31ffb8b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nazariig
force-pushed
the
master-trim-asym
branch
from
31ffb8b to
ef99e84
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
Unstable tests VS tests are: |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#68 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Collaborator
|
Cherry-pick PR to 202505: #1621 |
6 tasks
11 tasks
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Jul 12, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> The PR is intended to provide a fix for the change sonic-net/sonic-swss#1957 The old test behavior relies on a hardcoded max TC value of 255. Now it needs to be updated following the `SAI_SWITCH_ATTR_QOS_MAX_NUMBER_OF_TRAFFIC_CLASSES` attribute implementation in VS lib. Due to the circular dependency, in order to have clean `sonic-sairedis` CI, the current change should be merged first. **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 **What I did** * Updated mirror VS test **Why I did it** * To align the behaviour with a new VS lib implementation **How I verified it** 1. Run VS test ``` root@sonic: tests# pytest --dvsname=vs --log-cli-level=info -vvv test_mirror_port_span.py ======================================================================== test session starts ========================================================================= platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /root/work/debug/trim/asym/sonic-swss/tests plugins: flaky-3.7.0 collected 10 items test_mirror_port_span.py::TestMirror::test_PortMirrorQueue PASSED [ 10%] test_mirror_port_span.py::TestMirror::test_PortMirrorAddRemove PASSED [ 20%] test_mirror_port_span.py::TestMirror::test_PortMirrorMultiSpanAddRemove PASSED [ 30%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerAddRemove PASSED [ 40%] test_mirror_port_span.py::TestMirror::test_PortMultiMirrorPolicerAddRemove PASSED [ 50%] test_mirror_port_span.py::TestMirror::test_LAGMirrorSpanAddRemove PASSED [ 60%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerWithAcl PASSED [ 70%] test_mirror_port_span.py::TestMirror::test_PortMirrorLAGPortSpanAddRemove PASSED [ 80%] test_mirror_port_span.py::TestMirror::test_PortLAGMirrorUpdateLAG PASSED [ 90%] test_mirror_port_span.py::test_nonflaky_dummy PASSED [100%] ``` **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Jul 12, 2025
…#103) <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> The PR is intended to provide a fix for the change sonic-net/sonic-swss#1957 The old test behavior relies on a hardcoded max TC value of 255. Now it needs to be updated following the `SAI_SWITCH_ATTR_QOS_MAX_NUMBER_OF_TRAFFIC_CLASSES` attribute implementation in VS lib. Due to the circular dependency, in order to have clean `sonic-sairedis` CI, the current change should be merged first. **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 **What I did** * Updated mirror VS test **Why I did it** * To align the behaviour with a new VS lib implementation **How I verified it** 1. Run VS test ``` root@sonic: tests# pytest --dvsname=vs --log-cli-level=info -vvv test_mirror_port_span.py ======================================================================== test session starts ========================================================================= platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /root/work/debug/trim/asym/sonic-swss/tests plugins: flaky-3.7.0 collected 10 items test_mirror_port_span.py::TestMirror::test_PortMirrorQueue PASSED [ 10%] test_mirror_port_span.py::TestMirror::test_PortMirrorAddRemove PASSED [ 20%] test_mirror_port_span.py::TestMirror::test_PortMirrorMultiSpanAddRemove PASSED [ 30%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerAddRemove PASSED [ 40%] test_mirror_port_span.py::TestMirror::test_PortMultiMirrorPolicerAddRemove PASSED [ 50%] test_mirror_port_span.py::TestMirror::test_LAGMirrorSpanAddRemove PASSED [ 60%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerWithAcl PASSED [ 70%] test_mirror_port_span.py::TestMirror::test_PortMirrorLAGPortSpanAddRemove PASSED [ 80%] test_mirror_port_span.py::TestMirror::test_PortLAGMirrorUpdateLAG PASSED [ 90%] test_mirror_port_span.py::test_nonflaky_dummy PASSED [100%] ``` **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
Collaborator
mssonicbld
added a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jul 14, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> The PR is intended to provide a fix for the change sonic-net#1957 The old test behavior relies on a hardcoded max TC value of 255. Now it needs to be updated following the `SAI_SWITCH_ATTR_QOS_MAX_NUMBER_OF_TRAFFIC_CLASSES` attribute implementation in VS lib. Due to the circular dependency, in order to have clean `sonic-sairedis` CI, the current change should be merged first. **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 **What I did** * Updated mirror VS test **Why I did it** * To align the behaviour with a new VS lib implementation **How I verified it** 1. Run VS test ``` root@sonic: tests# pytest --dvsname=vs --log-cli-level=info -vvv test_mirror_port_span.py ======================================================================== test session starts ========================================================================= platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /root/work/debug/trim/asym/sonic-swss/tests plugins: flaky-3.7.0 collected 10 items test_mirror_port_span.py::TestMirror::test_PortMirrorQueue PASSED [ 10%] test_mirror_port_span.py::TestMirror::test_PortMirrorAddRemove PASSED [ 20%] test_mirror_port_span.py::TestMirror::test_PortMirrorMultiSpanAddRemove PASSED [ 30%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerAddRemove PASSED [ 40%] test_mirror_port_span.py::TestMirror::test_PortMultiMirrorPolicerAddRemove PASSED [ 50%] test_mirror_port_span.py::TestMirror::test_LAGMirrorSpanAddRemove PASSED [ 60%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerWithAcl PASSED [ 70%] test_mirror_port_span.py::TestMirror::test_PortMirrorLAGPortSpanAddRemove PASSED [ 80%] test_mirror_port_span.py::TestMirror::test_PortLAGMirrorUpdateLAG PASSED [ 90%] test_mirror_port_span.py::test_nonflaky_dummy PASSED [100%] ``` **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 2. sonic-net#3594 **HLD:** sonic-net/SONiC#1988 **What I did** * Implemented Packet Trimming Asymmetric DSCP feature **Why I did it** * Implementation is done according to the Packet Trimming Asymmetric DSCP HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jul 15, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 2. #3594 **HLD:** sonic-net/SONiC#1988 **What I did** * Implemented Packet Trimming Asymmetric DSCP feature **Why I did it** * Implementation is done according to the Packet Trimming Asymmetric DSCP HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Jul 31, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> The PR is intended to provide a fix for the change sonic-net#1957 The old test behavior relies on a hardcoded max TC value of 255. Now it needs to be updated following the `SAI_SWITCH_ATTR_QOS_MAX_NUMBER_OF_TRAFFIC_CLASSES` attribute implementation in VS lib. Due to the circular dependency, in order to have clean `sonic-sairedis` CI, the current change should be merged first. **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 **What I did** * Updated mirror VS test **Why I did it** * To align the behaviour with a new VS lib implementation **How I verified it** 1. Run VS test ``` root@sonic: tests# pytest --dvsname=vs --log-cli-level=info -vvv test_mirror_port_span.py ======================================================================== test session starts ========================================================================= platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-0.13.1 -- /usr/bin/python3 cachedir: .pytest_cache rootdir: /root/work/debug/trim/asym/sonic-swss/tests plugins: flaky-3.7.0 collected 10 items test_mirror_port_span.py::TestMirror::test_PortMirrorQueue PASSED [ 10%] test_mirror_port_span.py::TestMirror::test_PortMirrorAddRemove PASSED [ 20%] test_mirror_port_span.py::TestMirror::test_PortMirrorMultiSpanAddRemove PASSED [ 30%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerAddRemove PASSED [ 40%] test_mirror_port_span.py::TestMirror::test_PortMultiMirrorPolicerAddRemove PASSED [ 50%] test_mirror_port_span.py::TestMirror::test_LAGMirrorSpanAddRemove PASSED [ 60%] test_mirror_port_span.py::TestMirror::test_PortMirrorPolicerWithAcl PASSED [ 70%] test_mirror_port_span.py::TestMirror::test_PortMirrorLAGPortSpanAddRemove PASSED [ 80%] test_mirror_port_span.py::TestMirror::test_PortLAGMirrorUpdateLAG PASSED [ 90%] test_mirror_port_span.py::test_nonflaky_dummy PASSED [100%] ``` **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Aug 3, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 2. sonic-net/sonic-swss#3594 **HLD:** sonic-net/SONiC#1988 **What I did** * Implemented Packet Trimming Asymmetric DSCP feature **Why I did it** * Implementation is done according to the Packet Trimming Asymmetric DSCP HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
prabhataravind
pushed a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Aug 4, 2025
Signed-off-by: Nazarii Hnydyn <[email protected]> <!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **DEPENDS:** 1. sonic-net/sonic-sairedis#1610 2. sonic-net/sonic-swss#3594 **HLD:** sonic-net/SONiC#1988 **What I did** * Implemented Packet Trimming Asymmetric DSCP feature **Why I did it** * Implementation is done according to the Packet Trimming Asymmetric DSCP HLD **How I verified it** 1. Run Packet Trimming VS UTs **Details if related** * N/A #### A picture of a cute animal (not mandatory but encouraged) ``` .---. .----------- / \ __ / ------ / / \( )/ ----- ////// ' \/ ` --- //// / // : : --- // / / /` '-- // //..\\ ====UU====UU==== '//||\\` ''`` ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
DEPENDS:
HLD: sonic-net/SONiC#1988
Requires SAI API v1.16.1
A picture of a cute animal (not mandatory but encouraged)