Skip to content

[unittest ]Conditionally enable TestServerSaiMockChannel#1587

Merged
r12f merged 1 commit intosonic-net:masterfrom
jimmyzhai:fix_mock_method
Apr 26, 2025
Merged

[unittest ]Conditionally enable TestServerSaiMockChannel#1587
r12f merged 1 commit intosonic-net:masterfrom
jimmyzhai:fix_mock_method

Conversation

@jimmyzhai
Copy link
Contributor

@jimmyzhai jimmyzhai commented Apr 26, 2025

Use #ifdef MOCK_METHOD to conditionally enable TestServerSaiMockChannel. This macro is introduced in gmock 1.10, however slave buster has older version of gmock 1.8, within which compiling unittest/lib/TestServerSai.cpp fails.

Signed-off-by: Junhua Zhai <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jimmyzhai jimmyzhai marked this pull request as ready for review April 26, 2025 03:42
@jimmyzhai jimmyzhai requested a review from kcudnik April 26, 2025 03:43
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants