Skip to content

[SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM#1573

Merged
Pterosaur merged 8 commits intosonic-net:masterfrom
Pterosaur:test_update_master
Apr 14, 2025
Merged

[SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM#1573
Pterosaur merged 8 commits intosonic-net:masterfrom
Pterosaur:test_update_master

Conversation

@Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Apr 3, 2025

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur Pterosaur force-pushed the test_update_master branch from fd70c84 to ddab04f Compare April 12, 2025 23:35
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur force-pushed the test_update_master branch from 7557459 to fe06d2b Compare April 13, 2025 04:20
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur force-pushed the test_update_master branch from fe06d2b to a7f2271 Compare April 13, 2025 07:54
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur force-pushed the test_update_master branch from a7f2271 to 952ac21 Compare April 13, 2025 10:13
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur changed the title [Test Only]: Test update master [SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM Apr 13, 2025
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur requested a review from tjchadaga April 13, 2025 14:43
kcudnik
kcudnik previously approved these changes Apr 13, 2025
proxylib/Sai.cpp Outdated

SWSS_LOG_ERROR("not implemented, FIXME");

// TODO: Fix me
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment not needed if error message contains the same

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Signed-off-by: Ze Gan <ganze718@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur Pterosaur merged commit 940fbb9 into sonic-net:master Apr 14, 2025
15 checks passed
@bradh352
Copy link

This PR is causing build issues:

/bin/bash ../libtool  --tag=CXX   --mode=link g++ -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -I../lib -I../vslib -ansi -fPIC -pipe -std=c++14 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Wno-inline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -Wno-switch-default -Wconversion -Wno-psabi -Wcast-align=strict    -g -O2 -ffile-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security  -rdynamic -Wl,-z,relro -Wl,-z,now -o syncd syncd-main.o  libSyncd.a ../lib/libSaiRedis.a -L../meta/.libs -lsaimetadata -lsaimeta -ldl -lhiredis -lswsscommon -lsai -lpthread -lzmq    
libtool: link: g++ -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -I../lib -I../vslib -ansi -fPIC -pipe -std=c++14 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Wno-inline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -Wno-switch-default -Wconversion -Wno-psabi -Wcast-align=strict -g -O2 -ffile-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -rdynamic -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/syncd syncd-main.o  libSyncd.a ../lib/libSaiRedis.a -L../meta/.libs /sonic/src/sonic-sairedis/meta/.libs/libsaimetadata.so /sonic/src/sonic-sairedis/meta/.libs/libsaimeta.so -ldl -lhiredis -lswsscommon -lsai -lpthread -lzmq
libtool: link: g++ -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -I../lib -I../vslib -ansi -fPIC -pipe -std=c++14 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Wno-inline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -Wno-switch-default -Wconversion -Wno-psabi -Wcast-align=strict -g -O2 -ffile-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -Wl,-rpath -Wl,../lib/.libs -Wl,-rpath -Wl,../meta/.libs -Wl,-z -Wl,relro -Wl,-z -Wl,now -o .libs/syncd_tests syncd_tests-tests.o  libSyncd.a -lhiredis -lswsscommon -lpthread -L../lib/.libs /sonic/src/sonic-sairedis/lib/.libs/libsairedis.so -L../meta/.libs /sonic/src/sonic-sairedis/meta/.libs/libsaimetadata.so /sonic/src/sonic-sairedis/meta/.libs/libsaimeta.so -lzmq
/usr/bin/ld: libSyncd.a(libSyncd_a-VendorSai.o): in function `syncd::VendorSai::VendorSai()':
./syncd/./syncd/VendorSai.cpp:61: undefined reference to `sai_query_stats_st_capability'
/usr/bin/ld: ./syncd/./syncd/VendorSai.cpp:61: undefined reference to `sai_tam_telemetry_get_data'
collect2: error: ld returned 1 exit status

@kcudnik
Copy link
Collaborator

kcudnik commented Apr 22, 2025

reason explained here: sonic-net/sonic-buildimage#21614 (comment)

DavidZagury pushed a commit to DavidZagury/sonic-sairedis that referenced this pull request Apr 28, 2025
…-net#1573)

[SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM

---------

Signed-off-by: Ze Gan <ganze718@gmail.com>
yxieca pushed a commit to sonic-net/SONiC that referenced this pull request Jun 3, 2025
Pterosaur
Member
Pterosaur commented on Sep 1, 2024 • 
High frequency telemetry HLD initial version

PRs:
sonic-net/sonic-swss-common#1006
sonic-net/sonic-sairedis#1573

---------

Signed-off-by: Ze Gan <zegan@microsoft.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Janetxxx <janet970527@gmail.com>
Co-authored-by: Janetxxx <janet970527@gmail.com>
stephenxs pushed a commit to stephenxs/sonic-sairedis that referenced this pull request Aug 30, 2025
…-net#1573) (sonic-net#63)

* [SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM (sonic-net#1573)

[SAI]: Update SAI to support QUERY_STATS_ST_CAPABILITY and TAM

---------

Signed-off-by: Ze Gan <ganze718@gmail.com>

* Fix conflict

Signed-off-by: Ze Gan <ganze718@gmail.com>

---------

Signed-off-by: Ze Gan <ganze718@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants