[syncd] Move log set function after api initialize#1548
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Mar 20, 2025
Merged
[syncd] Move log set function after api initialize#1548kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
It may happen that in case of virtual switch, logset will be called before api initialize, which will log error messages, since VS was not initialized yet, and logSet in VS requires api to be initialized before call
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
stephenxs
approved these changes
Mar 5, 2025
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
|
hi @kcudnik, can this be merged? |
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#61 |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may happen that in case of virtual switch, logset will be called before api initialize, which will log error messages, since VS was not initialized yet, and logSet in VS requires api to be initialized before call