Revert "add if statement for module control mode support"#1341
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Jan 29, 2024
Merged
Revert "add if statement for module control mode support"#1341kcudnik merged 1 commit intosonic-net:masterfrom
kcudnik merged 1 commit intosonic-net:masterfrom
Conversation
kcudnik
approved these changes
Jan 23, 2024
Collaborator
|
@kcudnik would you please help to merge? |
mssonicbld
pushed a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Jan 31, 2024
…1341) Reverts sonic-net#1305 this logic is not needed. we'll change sai.profile directly
Collaborator
|
Cherry-pick PR to 202311: #1346 |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
6 similar comments
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@dbarashinvd cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 11, 2024
Reverts #1305 this logic is not needed. we'll change sai.profile directly
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1305
this logic is not needed. we'll change sai.profile directly