[VOQ][saidump] To move saidump.sh from the sonic-buildimage repo to the sairedis repo#1298
Merged
kcudnik merged 21 commits intosonic-net:masterfrom Oct 10, 2023
Merged
[VOQ][saidump] To move saidump.sh from the sonic-buildimage repo to the sairedis repo#1298kcudnik merged 21 commits intosonic-net:masterfrom
kcudnik merged 21 commits intosonic-net:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why did I do it?
To fix the issue: sonic-net/sonic-buildimage#13561
The existing saidump use https://github.com/sonic-net/sonic-swss-common/blob/master/common/table_dump.lua script which loops the ASIC_DB more than 5 seconds and blocks other processes access.
This solution uses the Redis SAVE command to save the snapshot of DB each time and recover later, instead of looping through each entry in the table.
Related PRs:
sonic-net/sonic-utilities#2972
sonic-net/sonic-buildimage#16466
#1288
In addition to the PR:
#1288
This PR is to address the below review comments:
To move saidump.sh from the sonic-buildimage repo to the sairedis repo.
sonic-net/sonic-buildimage#16466 (comment)
Work item tracking
Microsoft ADO (25892380):
How did I do it?
To use the Redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)