[FEC] Adding support for vs testing for SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE#1271
Merged
kcudnik merged 3 commits intosonic-net:masterfrom Aug 9, 2023
Merged
[FEC] Adding support for vs testing for SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE#1271kcudnik merged 3 commits intosonic-net:masterfrom
kcudnik merged 3 commits intosonic-net:masterfrom
Conversation
Junchao-Mellanox
approved these changes
Aug 6, 2023
kcudnik
approved these changes
Aug 6, 2023
Collaborator
|
@kcudnik could you pls help to review? |
Collaborator
|
i already reviewed and approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support to test SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE. We need to test two flows one with attribute supported and one without.
Added logic where MLNX2700 has support for the attribute wheile BCM56850 doesn't have support
Added UT to verify.