[syncd] Add pre match logic for acl entry (#1240)#1257
Merged
kcudnik merged 1 commit intosonic-net:202012from Jul 10, 2023
Merged
[syncd] Add pre match logic for acl entry (#1240)#1257kcudnik merged 1 commit intosonic-net:202012from
kcudnik merged 1 commit intosonic-net:202012from
Conversation
this will test scenario where we have 1 acl entry with counter and after warm boot 2 acl entries and 2 counters the same which could end up matching wrong acl counter and causing fail "object exist" on broadcom acl entry set, which will require improve pre match logic for acl entry
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
seems like build pipeline is broken here |
Contributor
|
@xumia @liushilongbuaa , the 202012 branch build pipeline seems break, could you please help check? |
Contributor
|
sonic-net/sonic-swss-common#780 needs to be cherry-picked to 202012 branch (similar to how #1238 was cherry-picked to 202012 branch for this repo). |
saiarcot895
approved these changes
Jun 29, 2023
Collaborator
Author
who can fix this ? |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@kcudnik, I think this can be merged now? |
11 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 16, 2023
…#16020) #### Why I did it Commits: 1. Use github code scanning instead of LGTM: sonic-net/sonic-sairedis#1160 2. [202012][submodule][SAI]Advance SAI head : sonic-net/sonic-sairedis#1211 3. Use github code scanning instead of LGTM: sonic-net/sonic-sairedis#1223 4. [syncd] Add pre match logic for acl entry: sonic-net/sonic-sairedis#1257 5. Fix pipeline issue caused by urllib3 v2: sonic-net/sonic-sairedis@26e5471 ##### Work item tracking - Microsoft ADO **(number only)**: 17914573
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will test scenario where we have 1 acl entry with counter and after warm boot 2 acl entries and 2 counters the same which could end up matching wrong acl counter and causing fail "object exist" on broadcom acl entry set, which will require improve pre match logic for acl entry