Revert "Ignore removing switch for mellanox platform due to known limitation (#1216)"#1233
Merged
kcudnik merged 1 commit intosonic-net:masterfrom Apr 28, 2023
Merged
Conversation
…itation (sonic-net#1216)" This reverts commit acd57ae.
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Apr 24, 2023
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @kcudnik , could you please help merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did?
This reverts commit acd57ae.
Why I did this?
This commit introduces a race condition with would cause syncd crash. The issue happens when: