[202211] Revert "Ignore removing switch for mellanox platform due to known limitation (#1216)"#1232
Merged
qiluo-msft merged 1 commit intosonic-net:202211from May 1, 2023
Conversation
…itation (sonic-net#1216)" This reverts commit 62aa244.
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Apr 24, 2023
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-sairedis |
Collaborator
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Apr 28, 2023
Collaborator
|
@StormLiangMS would you please help merge? |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-sairedis submodule pointer to include the following: * 61cf1ce Revert Ignore removing switch for mellanox platform due to known limitation (1216) ([sonic-net#1232](sonic-net/sonic-sairedis#1232)) Signed-off-by: dprital <drorp@nvidia.com>
10 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
May 2, 2023
Update sonic-sairedis submodule pointer to include the following: * 61cf1ce Revert Ignore removing switch for mellanox platform due to known limitation (1216) ([#1232](sonic-net/sonic-sairedis#1232)) Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did?
This reverts commit 62aa244.
Why I did this?
This commit introduces a race condition with would cause syncd crash. The issue happens when:
Syncd.m_sn has been freed
SAI send a port state change notification which will access Syncd.m_sn ===> causes crash