Skip to content

[SAI submodule update] Enable support for SAI v1.11.0#1140

Merged
richardyu-ms merged 4 commits intosonic-net:masterfrom
richardyu-ms:update_sai1.11_master
Nov 16, 2022
Merged

[SAI submodule update] Enable support for SAI v1.11.0#1140
richardyu-ms merged 4 commits intosonic-net:masterfrom
richardyu-ms:update_sai1.11_master

Conversation

@richardyu-ms
Copy link
Contributor

@richardyu-ms richardyu-ms commented Oct 21, 2022 •
edited
Loading

Support SAI submodule with version v1.11.0

In order to support new APIs from SAI 1.11, the changes below

  1. add definitions for new APIs including
    • sai_redis_next_hop_group
     redis_bulk_set_next_hop_group_members
 redis_bulk_get_next_hop_group_members
    • sai_redis_neighbor
    REDIS_BULK_QUAD_API(neighbor_entry)
    • sai_redis_switch
     redis_switch_mdio_cl22_read,
 redis_switch_mdio_cl22_write
    • sai_redis_tunnel
    REDIS_BULK_QUAD_API(tunnels)
  2. implementations for all those APIs (stubs)
  3. Add unit test for all those interfaces

Test done:

Test with new unit tests for all the interfaces (meets the code coverage requirement)
Test the binary in test bed

Signed-off-by: richardyu-ms richard.yu@microsoft.com

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 22, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: richardyu-ms / name: Richard.Yu (35cf54c)

@richardyu-ms richardyu-ms force-pushed the update_sai1.11_master branch from 218a7f9 to 35cf54c Compare October 22, 2022 15:52
@richardyu-ms
Copy link
Contributor Author

richardyu-ms commented Oct 22, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 22, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@kcudnik
Copy link
Collaborator

kcudnik commented Oct 24, 2022

looks good, but check build errors

@jimmyzhai
Copy link
Contributor

jimmyzhai commented Oct 27, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 27, 2022

Azure Pipelines successfully started running 1 pipeline(s).

kcudnik
kcudnik previously approved these changes Oct 27, 2022
View reviewed changes
@prsunny
Copy link
Contributor

prsunny commented Nov 4, 2022

@richardyu-ms , can we merge this?

@richardyu-ms
Copy link
Contributor Author

richardyu-ms commented Nov 7, 2022

@richardyu-ms , can we merge this?

Still cannot merge this PR, cause this change will break the image build for some vendors in sonic-buildimage, and need a correlated upgrade or a period for the acknowledgment.
Already notify some impacted vendors.

@richardyu-ms
Copy link
Contributor Author

richardyu-ms commented Nov 11, 2022

/azp run coverage.Azure.sonic-sairedis.amd64

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 11, 2022

No pipelines are associated with this pull request.

@richardyu-ms richardyu-ms requested a review from kcudnik November 11, 2022 08:12
@richardyu-ms
Copy link
Contributor Author

richardyu-ms commented Nov 11, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 11, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@richardyu-ms
Copy link
Contributor Author

richardyu-ms commented Nov 12, 2022

/azp run Azure.sonic-sairedis

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 12, 2022

Azure Pipelines successfully started running 1 pipeline(s).

jimmyzhai
jimmyzhai reviewed Nov 15, 2022
View reviewed changes
@richardyu-ms
upgrade to latest sai 1.11
56dfdb4 
add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
jimmyzhai
jimmyzhai previously approved these changes Nov 15, 2022
View reviewed changes
@richardyu-ms
refactor code
417a4ba 
Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@richardyu-ms richardyu-ms merged commit 7413c70 into sonic-net:master Nov 16, 2022
@richardyu-ms richardyu-ms deleted the update_sai1.11_master branch November 16, 2022 03:03
richardyu-ms added a commit to richardyu-ms/sonic-sairedis that referenced this pull request Nov 16, 2022
@richardyu-ms
[SAI submodule update] Enable support for SAI v1.11.0 (sonic-net#1140)
b6468f4 
* [SAI submodule update] Enable support for SAI v1.11.0

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* update SAI for saithift fix

* upgrade to latest sai 1.11

add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* refactor code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
@richardyu-ms richardyu-ms mentioned this pull request Nov 16, 2022
Merged
richardyu-ms added a commit that referenced this pull request Nov 16, 2022
@richardyu-ms
[SAI submodule update] Enable support for SAI v1.11.0 (#1140)
95105fc 
* [SAI submodule update] Enable support for SAI v1.11.0

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* update SAI for saithift fix

* upgrade to latest sai 1.11

add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* refactor code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@richardyu-ms
[SAI submodule update] Enable support for SAI v1.11.0 (sonic-net#1140)
7a7fd2c 
* [SAI submodule update] Enable support for SAI v1.11.0

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* update SAI for saithift fix

* upgrade to latest sai 1.11

add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* refactor code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
This was referenced Nov 23, 2022
Merged
Merged
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 30, 2022
@richardyu-ms @pettershao-ragilenetworks
[SAI submodule update] Enable support for SAI v1.11.0 (sonic-net#1140)
7dff82e 
* [SAI submodule update] Enable support for SAI v1.11.0

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* update SAI for saithift fix

* upgrade to latest sai 1.11

add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* refactor code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 30, 2022
@richardyu-ms @pettershao-ragilenetworks
[SAI submodule update] Enable support for SAI v1.11.0 (sonic-net#1140)
95891d7 
* [SAI submodule update] Enable support for SAI v1.11.0

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* update SAI for saithift fix

* upgrade to latest sai 1.11

add cases

fix a code issue

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

* refactor code

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmyzhai jimmyzhai jimmyzhai approved these changes

@kcudnik kcudnik Awaiting requested review from kcudnik

Assignees

No one assigned

Labels

Included in 202211 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardyu-ms @kcudnik @jimmyzhai @prsunny @StormLiangMS