Skip to content

[gbsyncd] Add asic db prefix for channel NOTIFICATIONS #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jimmyzhai merged 5 commits into from
Oct 21, 2022
Merged

[gbsyncd] Add asic db prefix for channel NOTIFICATIONS #1129

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c833246
Use channelName GBNOTIFICATIONS for gbsyncd
jimmyzhai Sep 19, 2022
27d7244
Merge branch 'master' into gbsyncd
jimmyzhai Oct 18, 2022
6e9378b
Add REDIS_TABLE_NOTIFICATIONS_PER_DB
jimmyzhai Oct 18, 2022
d8ed45a
ignore 'pubsub'
jimmyzhai Oct 18, 2022
b65b6b2
ignore 'io' in spell check
jimmyzhai Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/RedisChannel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ RedisChannel::RedisChannel(
m_getConsumer = std::make_shared<swss::ConsumerTable>(m_db.get(), REDIS_TABLE_GETRESPONSE);

m_dbNtf = std::make_shared<swss::DBConnector>(dbAsic, 0);
m_notificationConsumer = std::make_shared<swss::NotificationConsumer>(m_dbNtf.get(), REDIS_TABLE_NOTIFICATIONS);
m_notificationConsumer = std::make_shared<swss::NotificationConsumer>(m_dbNtf.get(),
dbAsic == "GB_ASIC_DB" ? REDIS_TABLE_GBNOTIFICATIONS : REDIS_TABLE_NOTIFICATIONS);

m_runNotificationThread = true;

Expand Down
5 changes: 5 additions & 0 deletions lib/sairediscommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
*/
#define REDIS_TABLE_NOTIFICATIONS "NOTIFICATIONS"

/**
* @brief Table which will be used to forward notifications from gbsyncd.
*/
#define REDIS_TABLE_GBNOTIFICATIONS "GBNOTIFICATIONS"
Copy link
Copy Markdown
Collaborator

@kcudnik kcudnik Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why GB needs different communication channel? channels are based on databases, for example ASIC_DB, so if GB will have different database then it will have separate communication channel for notifications and they will not colide

Copy link
Copy Markdown
Collaborator

@kcudnik kcudnik Sep 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this could be generalizaed by chaning notifications channel name by prefixing it by db name
for example dbAsic + REDIS_TABLE_NOTIFICATIONS, then it would be more generic, and i think this would be proffered way to make this change

Copy link
Copy Markdown
Contributor Author

@jimmyzhai jimmyzhai Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redis channel is global per instance. Do you prefer to the below?

#define REDIS_GB_ASIC_NOTIFICATIONS "GB_ASIC_NOTIFICATIONS"

"NOTIFICATIONS" has been widely referred as asic channel. I'll not rename it.

Copy link
Copy Markdown
Collaborator

@kcudnik kcudnik Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think more preffered way would be to use that asic db prefix

Copy link
Copy Markdown
Contributor Author

@jimmyzhai jimmyzhai Oct 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add REDIS_TABLE_NOTIFICATIONS_PER_DB(dbName)


/**
* @brief Table which will be used to send API response from syncd.
*/
Expand Down
3 changes: 2 additions & 1 deletion syncd/RedisNotificationProducer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ RedisNotificationProducer::RedisNotificationProducer(

m_db = std::make_shared<swss::DBConnector>(dbName, 0);

m_notificationProducer = std::make_shared<swss::NotificationProducer>(m_db.get(), REDIS_TABLE_NOTIFICATIONS);
m_notificationProducer = std::make_shared<swss::NotificationProducer>(m_db.get(),
dbName == "GB_ASIC_DB" ? REDIS_TABLE_GBNOTIFICATIONS : REDIS_TABLE_NOTIFICATIONS);
}

void RedisNotificationProducer::send(
Expand Down