Fix for [EVPN] When MAC moves from remote end point to local, ASIC DB fields are not updated properly for the mac #11503Update NotificationProcessor.cpp

[anilkpan]

Issue:
When a mac moves from remote to local, the local mac is set in ASIC db using hset, which updates common fields, but does not remove fields specific to remote mac.

Fix:
In case of a mac move event, remove the existing FDB entry from ASIC DB first and then set the new one.

[dgsudharsan]

@anilkpan Can you please add UT for the coverage?

[dgsudharsan]

@kcudnik Can you please review?

[anilkpan]

I will work on adding the PTF test for mac move. ETA end of the month.

[kcudnik]

please satisfy code coverage via unittests

[dgsudharsan]

I will work on adding the PTF test for mac move. ETA end of the month.

Hi @anilkpan Not sure if PTF tests will satisfy the coverage. I believe you need to add gtest here. Can you please check?

[kcudnik]

yes i was suggesting to add tests unittests here

[anilkpan]

I will work on adding the PTF test for mac move. ETA end of the month.

Hi @anilkpan Not sure if PTF tests will satisfy the coverage. I believe you need to add gtest here. Can you please check?

@dgsudharsan, i will start working on adding the unittest next week.

[dgsudharsan]

@anilkpan Can you please provide ETA for UT?

[anilkpan]

@dgsudharsan, I have coded the gtest for this scenario. Is there a document that describes how to run the tests locally?

[dgsudharsan]

@dgsudharsan, I have coded the gtest for this scenario. Is there a document that describes how to run the tests locally?

@kcudnik Can you please help here?

[kcudnik]

@dgsudharsan, I have coded the gtest for this scenario. Is there a document that describes how to run the tests locally?

@kcudnik Can you please help here?

to run locally go to the desired directory and type "make check" and it will run all tests

[anilkpan]

@dgsudharsan, I have coded the gtest for this scenario. Is there a document that describes how to run the tests locally?

@kcudnik Can you please help here?

to run locally go to the desired directory and type "make check" and it will run all tests

Thanks @kcudnik, i will try this.

[anilkpan]

@kcudnik, 'make check' seems to need libsaimetadata.so.0, which was not built. Any ideas what I am missing?

make check-TESTS
make[1]: Entering directory '/home/anilkpandey/sonic-buildimage/src/sonic-sairedis/lib'
/home/anilkpandey/sonic-buildimage/src/sonic-sairedis/lib/.libs/tests: error while loading shared libraries: libsaimetadata.so.0: cannot open shared object file: No such file or directory
FAIL: tests

1 of 1 test failed

Makefile:1592: recipe for target 'check-TESTS' failed

[kcudnik]

hmm, it should be build, can you type "make" first in top directory to build everyting ?

[dgsudharsan]

@anilkpan Can you please provide ETA of adding the coverage?

[anilkpan]

@dgsudharsan, I plan to add the test by end of next week.

[anilkpan]

need to check why the test is failing, will take few more days.

[dgsudharsan]

@anilkpan Is there any update on this PR?

[anilkpan]

@dgsudharsan, The test is failing. Is the syslog or the core dump available for the test run so that I can debug the failure?

[dgsudharsan]

@dgsudharsan, The test is failing. Is the syslog or the core dump available for the test run so that I can debug the failure?

@vivekrnv Can you please help here?

[vivekrnv]

@dgsudharsan, The test is failing. Is the syslog or the core dump available for the test run so that I can debug the failure?

Hi, There must be a test binary/executable found after you run make. invoke the binary with gdb to drop into a shell. Set breakpoints in you code and debug.
Additionally you can use --gtest_filter to only run the test you want to check.

[dgsudharsan]

@anilkpan Were you able to proceed? Can you please provide ETA?

[anilkpan]

Thanks @vivekrnv.
@dgsudharsan, I have added the fix, checks look good so far.

[dgsudharsan]

@kcudnik Can we merge this?

[dgsudharsan]

Request for 202211 branch

[dgsudharsan]

@prsunny @yxieca Can we add label for 202205 and 202211 for this PR?

[yxieca]

@anilkpan, @dgsudharsan this change cannot be cherry-picked cleanly. Please open new PR.

[dgsudharsan]

@anilkpan Can you please raise a separate PR for 202205?

[anilkpan]

@dgsudharsan, working on it, ETA 12/22

[anilkpan]

@dgsudharsan, created PR #1173 on 202205 branch.